[wp-meta] [Making WordPress.org] #974: Make WordPress.tv theme responsive

Making WordPress.org noreply at wordpress.org
Sat May 9 01:12:07 UTC 2015


#974: Make WordPress.tv theme responsive
-------------------------+-------------------------------------------------
  Reporter:  BrashRebel  |      Owner:  iandunn
      Type:              |     Status:  accepted
  enhancement            |  Component:  WordPress.tv
  Priority:  normal      |   Keywords:  good-first-bug has-patch dev-
Resolution:              |  feedback
-------------------------+-------------------------------------------------

Comment (by iandunn):

 `974.diff` is a really good first step, it solves most of the problems,
 but I think there's some more work to do before it's finished.

 I made some changes to get us a little closer:

 * Moved media queries to the bottom, to comply with
 [https://make.wordpress.org/core/handbook/coding-standards/css/#media-
 queries the coding standards].

 * Replaced the accordion menu with the `_s` equivalent. The accordion
 wasn't working for me in Firefox, and it duplicates the markup and doesn't
 have the accessibility features that the `_s` one does. I also styled the
 menu a bit, but it could definitely be improved further.

 * Centered the list items at smaller resolutions, to make them easier to
 read.

 * Made the widgets use more of the empty space at tablet-sized
 resolutions.

 I also left some `todo` notes with a few things that I noticed aren't
 working, but didn't have time to fix.

 * The video player is collapsing when the video starts to play, because of
 messing w/ the container height. I think some of my changes may have made
 this worse :) It may be better to stick with a fixed width and just center
 the player, instead of trying to make it grow/shrink w/ the viewport.
 * Secondary videos are overflowing their containers on small screens,
 because of the janky way they were originally setup w/ absolutely
 positioned thumbnails and padding to push the title over.
 * I think there'll be a few more things that come up in testing, but
 nothing major.

 I committed a few small things, and then generated a new patch with my
 changes.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/974#comment:7>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list