[wp-meta] [Making WordPress.org] #986: Display video producer credit on WPTV posts

Making WordPress.org noreply at wordpress.org
Tue Jun 16 13:56:18 UTC 2015

#986: Display video producer credit on WPTV posts
  Reporter:  iandunn      |      Owner:  iandunn
      Type:  enhancement  |     Status:  accepted
  Priority:  normal       |  Component:  WordPress.tv
Resolution:               |   Keywords:  good-first-bug has-patch

Comment (by iandunn):

 I made some minor tweaks in `986.3.diff`, but overall this looks great :)

 `strpos()` can return `0`, which PHP will evaluate as `false`, so the
 strict comparison operator (`===`) was needed in

 I removed calls to `validate_username()` and `sanitize_user()` because
 WordPress.org usernames are created with bbPress, which allows capitals
 (e.g., [https://profiles.wordpress.org/Ian%20Dunn%20Space%20Capital%20Test
 Ian Dunn Space Capital Test]). They weren't really needed anyway, because
 the `grav-redirect` call will ensure that invalid usernames are thrown

 The producer username should probably be taxonomy like the producer name
 was, rather than meta data, right? I think it makes sense to think of that
 as a taxonomy, it makes it more performant to query, and we get the
 archive page for free, in case we want to use that in future, like we
 discussed above.

 I added a section to the Contributing With Git page about applying
 patches, can you test that out with `986.3.diff`?

Ticket URL: <https://meta.trac.wordpress.org/ticket/986#comment:26>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list