[wp-meta] [Making WordPress.org] #470: Add Infinite Scrolling to WordPress Events plugin
Making WordPress.org
noreply at wordpress.org
Sat Jan 3 06:33:31 UTC 2015
#470: Add Infinite Scrolling to WordPress Events plugin
-------------------------+-------------------------------------------------
Reporter: iandunn | Owner:
Type: | Status: new
enhancement | Component: make.wordpress.org / P2
Priority: normal | Keywords: needs-patch good-first-bug needs-
Resolution: | testing dev-feedback
-------------------------+-------------------------------------------------
Changes (by bansod_deven):
* keywords: needs-patch good-first-bug => needs-patch good-first-bug
needs-testing dev-feedback
Comment:
Hey Utkarsh,
The Patch looks good.
But as you mentioned, the diffs uploaded here do not seem to be in proper
format. Also, you don't have to upload 2 different patches for 2 different
files. Changes in both files can be included in the same patch. Just go to
the root of your working copy. Just do
{{{
svn diff > patch_name.diff
}}}
If you have added any new files not present in working copy(which is not
the case here), then you might have to do
{{{
svn add path_to_new_file
}}}
Also there were some formatting and coding standards mistakes that I
found, I have changed them accordingly and also merged the 2 patches into
one. Please review if the changes are right or you can always remove those
changes.
'''Edited Patch Added.'''
Needs Testing though. Please make any changes if you want.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/470#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list