[wp-meta] [Making WordPress.org] #558: CampTix "Country" question type

Making WordPress.org noreply at wordpress.org
Thu Jan 1 20:38:50 UTC 2015


#558: CampTix "Country" question type
-------------------------+-------------------------------------------------
  Reporter:              |      Owner:
  vanillalounge          |     Status:  closed
      Type:              |  Component:  wordcamp.org
  enhancement            |   Keywords:  good-first-bug reporter-feedback
  Priority:  normal      |  needs-testing
Resolution:  fixed       |
-------------------------+-------------------------------------------------
Changes (by iandunn):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 That source looks good, and I think we should include them all.

 I made a few small changes before committing:

 * Added `selected()` to the `<option>` elements, so the chosen value will
 be selected if there's an error during submission and the form is
 redisplayed, and when editing an attendee.
 * Setup the country list as an array to begin with, rather than a string
 that gets converted to an array.
 * Sorted the array alphabetically.
 * Removed the `[camptix_attendee]` callbacks after I realized we probably
 don't want the country showing up in attendee list.

 Committed in
 [https://github.com/Automattic/camptix/commit/bdd615d6e382b442664b0996e58f46dea03a137d
 bdd615d].

 Thanks Deven :)

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/558#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list