[wp-meta] [Making WordPress.org] #558: CampTix "Country" question type

[Making WordPress.org]

#558: CampTix "Country" question type
-------------------------+-------------------------------------------------
  Reporter:              |      Owner:
  vanillalounge          |     Status:  new
      Type:              |  Component:  wordcamp.org
  enhancement            |   Keywords:  good-first-bug reporter-feedback
  Priority:  normal      |  needs-testing
Resolution:              |
-------------------------+-------------------------------------------------

Comment (by iandunn):

 Hey Deven, thanks for the patch :)

 Overall it looks good, but there are a few things I think we should
 change.

 1. We don't need to show the list of countries in the back-end, or save it
 in the `postmeta` for every `tix_question`, we can just output the
 hardcoded list on the front-end for the visitor, similar to how the
 Twitter and URL fields don't ask for anything.
 1. `question_field_country()`, etc should be in `addons/field-country.php`
 rather than `camptix.php`, because addons shouldn't modify core CampTix
 (just like WordPress plugins don't modify Core files). It's fine to add it
 to `$default_addons`, though.
 1. The patch should be compliant with
 [http://make.wordpress.org/core/handbook/coding-standards/ WP's coding
 standards] (braces around single lines, etc).
 1. Escape output as late as possible, e.g., during the `printf` rather
 than the `$country = ...`
 1. Remove debugging code like `// echo $country;`


 Also, where did the list of countries come from? We'll want to make sure
 it matches the official ISO 3166-1 list.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/558#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org