[wp-meta] [Making WordPress.org] #876: Icons in front of external links are missing

[Making WordPress.org]

#876: Icons in front of external links are missing
------------------------+------------------
Reporter:  morganestes  |      Owner:
    Type:  defect       |     Status:  new
Priority:  normal       |  Component:  Trac
Keywords:  needs-patch  |
------------------------+------------------
 It appears that there should be an icon in front of links inside comments
 on tickets indicating that they're external links, but there's just an
 empty space where the image is supposed to be.

 One example of the markup is:
 {{{
 <a class="ext-link" href="https://make.wordpress.org/chat/">
 <span class="icon">​</span>Slack</a> in #core by morganestes.
 <a class="ext-link"
 href="https://wordpress.slack.com/archives/core/p1424299563005495"><span
 class="icon">​</span>View the logs</a>
 }}}

 The styles that are applied to this include a background image for `.ext-
 link .icon` set in `trac.css` but overridden and set to `display:none` in
 `wp-trac.css`, and inserted content of `"\f316"` on `a.ext-link:before`. I
 can't find any record of that icon on
 https://developer.wordpress.org/resource/dashicons/, but the dashicons
 stylesheet loaded indicates it's a download icon, which doesn't seem
 appropriate in this case.

 {{{
 .dashicons-download:before {
     content: "\f316"
 }
 }}}

 Removing the `display:none` rule from  `.ext-link .icon` in `wp-trac.css`
 shows the background image icon but doesn't fix the left padding issue
 caused by the missing icon styles.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/876>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org