[wp-meta] [Making WordPress.org] #470: Add Infinite Scrolling to WordPress Events plugin

Making WordPress.org noreply at wordpress.org
Sat Feb 7 01:10:12 UTC 2015

#470: Add Infinite Scrolling to WordPress Events plugin
  Reporter:  iandunn     |      Owner:  iandunn
      Type:              |     Status:  accepted
  enhancement            |  Component:  make.wordpress.org / P2
  Priority:  normal      |   Keywords:  needs-patch good-first-bug needs-
Resolution:              |  testing
Changes (by iandunn):

 * keywords:  needs-patch good-first-bug needs-testing dev-feedback =>
     needs-patch good-first-bug needs-testing
 * owner:   => iandunn
 * status:  new => accepted


 Thanks, this looks good. I think the next step is to get WordCamps pulled
 in too. The JSON API isn't currently active on wordcamp.org, but if you
 change `WORDCAMP_API_BASE_URL` to point to your local sandbox you can
 simulate it. You can use the [https://github.com/iandunn/wordpress-meta-
 environment Meta Environment] to setup a local version of WordCamp.org to
 pull sample data from.

 Here's a few minor things I noticed:

 * `wp_json_send_*()` functions calls `die()`, so you don't need to
 `return` after them.
 * `wp_localize_script()` is the standard method for outputting JavaScript
 variables like `ajaxurl`
 * `ajaxurl` should have the plugin prefix, to avoid conflicts with the
 Core variable that other plugins may enqueue
 * `$offset++` is a cleaner way of writing `$offset = $offset + 1;`.
 * `esc_url()` is more restrictive than `esc_attr()`, so it's not necessary
 to wrap `esc_url()` calls in `esc_attr()`.
 * Data passed to `wp_send_json_*()` will be automatically passed through
 `json_encode()`, so you don't need to do it manually.

 I uploaded a refreshed patch, since some other changes were made to the
 plugin since it was uploaded.

Ticket URL: <https://meta.trac.wordpress.org/ticket/470#comment:10>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list