[wp-meta] [Making WordPress.org] #1445: "Add translation" button should be re-enabled on error when saving
Making WordPress.org
noreply at wordpress.org
Wed Dec 23 05:26:13 UTC 2015
#1445: "Add translation" button should be re-enabled on error when saving
-----------------------------+-------------------------------------
Reporter: SergeyBiryukov | Owner:
Type: defect | Status: new
Priority: normal | Component: translate.wordpress.org
Resolution: | Keywords: has-patch
-----------------------------+-------------------------------------
Changes (by diddledan):
* keywords: => has-patch
Comment:
Explanation:
WP.org includes a function that hijacks glotpress' default click handler
on the affected button and tries to pass the button as an argument to
glotpress' `ok` javascript function in `glotpress/js/editor.js` which
expects the button to be assigned to `this` instead of passed as an
argument. My fix therefore uses `Function.call` to redefine the `this`
value in the `ok` function when executed.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1445#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list