[wp-meta] [Making WordPress.org] #610: Add post types to 'At a Glance' dashboard widget
Making WordPress.org
noreply at wordpress.org
Wed Sep 17 16:06:25 UTC 2014
#610: Add post types to 'At a Glance' dashboard widget
--------------------------+--------------------------
Reporter: hlashbrooke | Owner: iandunn
Type: enhancement | Status: accepted
Priority: low | Component: wordcamp.org
Resolution: | Keywords: has-patch
--------------------------+--------------------------
Changes (by iandunn):
* owner: => iandunn
* priority: normal => low
* status: new => accepted
Comment:
This sounds like a good idea. A few comments on `610.diff`:
* `tix_attendee` isn't part `wc-post-types`, so I'm leery of including
that in `glance_items()`; it seems wrong to couple the two plugins
together. It's not ideal to duplicate the code in both plugins either, but
since CampTix is distributed as a generic plugin -- as opposed to only
being used on WordCamp.org -- then I think that's probably the best
compromise in this situation.
* The text domain we use is `wordcamporg`.
* The coding standards now call for braces around all conditions (line
`1665`), and spaces between control structures and their opening
parentheses.
* On `1665`, do we want `if ( isset( $num_posts->publish ) &&
$num_posts->publish )` instead? `if ( $num_posts )` will always evaluate
to `true`, because `wp_count_posts()` always returns an `object`.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/610#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list