[wp-meta] [Making WordPress.org] #447: Link to actual source from reference pages

[Making WordPress.org]

#447: Link to actual source from reference pages
---------------------------+-------------------------------------
  Reporter:  DrewAPicture  |      Owner:
      Type:  enhancement   |     Status:  new
  Priority:  normal        |  Component:  developer.wordpress.org
Resolution:                |   Keywords:  has-patch
---------------------------+-------------------------------------

Comment (by coffee2code):

 I'm on board with the function renaming and repurposing as proposed (with
 some minor nitpicks*).

 I'm not quite in agreement with the front end implementation. Attached is
 [attachment:447.png] which demonstrates the changes made in
 [attachment:447.diff].

 The "Source:" filename originally/currently points to the source file
 archive (e.g. https://developer.wordpress.org/reference/files/wp-
 includes/functions.php). The patch changes that to point to the trac
 browser view of the function (e.g.
 https://core.trac.wordpress.org/browser/tags/3.9/src/wp-
 includes/functions.php#L2873) and adds a new link, "More in this file...",
 that links to the source file archive.

 I prefer the "Source:" link to be unchanged (the source file name linking
 to the source file archive), and that we add a "View source" link
 somewhere. Verbiage and location could do with additional input. @sams?
 @siobhan? If the consensus if for what @DrewAPicture proposed, I'm fine
 with that.


 ----
 Nitpicks:

 * I'd prefer to `esc_url()` late (when `get_source_file_link()` gets used
 and not in it)
 * The core.trac link should point to the tagged release and not to trunk,
 since trunk will always be in flux, likely causing line numbers to not
 sync up.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/447#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org