[wp-meta] [Making WordPress.org] #505: Plugins Zip Builder Tags v. Branches namespacing conflict
Making WordPress.org
noreply at wordpress.org
Sat Jun 7 04:49:33 UTC 2014
#505: Plugins Zip Builder Tags v. Branches namespacing conflict
-------------------------------------+-------------------------------
Reporter: georgestephanis | Owner:
Type: defect | Status: new
Priority: normal | Component: Plugins Directory
Keywords: needs-patch dev-feedback |
-------------------------------------+-------------------------------
If a software project like bbPress runs tags and branches named the same
-- for example, having a structure that looks something like
{{{
/branches/2.5/
/tags/2.5/
/tags/2.5.1/
/tags/2.5.2/
/tags/2.5.3/
/tags/2.5.4/
}}}
and keeps the 2.5 branch up to date, so that it is reflecting the current
2.5.4 release, the download of the 2.5 release will actually be the 2.5.4
release.
Test it for yourself: http://wordpress.org/plugins/bbpress/developers/
This is because of a naming conflict when branches and tags have their zip
packages made.
Tags are generated as:
{{{
http://downloads.wordpress.org/plugin/plugin.{$tag_directory}.zip
}}}
Branches are generated as:
{{{
http://downloads.wordpress.org/plugin/plugin.{$branch_directory}.zip
}}}
If they have the same name, then I believe the zips are regenerated as the
files in that directory is modified? Regardless, the zip of the 2.5
tagged release gets overwritten with the 2.5 branch.
This is particularly problematic if current stable is 2.5, and a 2.5.1
point release is being prepared in the 2.5 branch. Code that may not be
yet meant for release into the world is getting delivered to every user
that installs or upgrades to current stable.
This is bad.
Ideal and I suspect easiest resolution would be to change the branch zip
filenames to
{{{
http://downloads.wordpress.org/plugin/plugin.branch.{$branch_directory}.zip
}}}
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/505>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list