[wp-meta] [Making WordPress.org] #567: Automate Speaker and Session CPT creation

Making WordPress.org noreply at wordpress.org
Tue Jul 29 17:35:31 UTC 2014


#567: Automate Speaker and Session CPT creation
--------------------------+--------------------------
  Reporter:  nvwd         |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Component:  wordcamp.org
Resolution:               |   Keywords:
--------------------------+--------------------------

Comment (by iandunn):

 This is looking pretty good :)

 I tested it out and made a few changes, so let me know what you think.

 * I removed the `h3` headings. They made the form much more readable, but
 unfortunately Jetpack will strip them out whenever the organizer edits the
 form.
 * Jetpack also strips the `id` attributes when the organizer edits the
 form, so we have to use the ids grunion generates instead. e.g., `g[post-
 id]-[slug]`
 * I split `check_call_for_speakers_for_login()` into two functions. Even
 though at the technical implementation level, the `if() / else()` is
 elegant, it's really doing two different things at the abstract level.
 It's best for a function to only do one thing. Granted, the definition of
 "one thing" can change based on the context, but I think it keeps the code
 more modular and decoupled this way. Having two functions also lets us
 give each function a more specific and meaningful name, which helps make
 the code self-documenting.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/567#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list