[wp-meta] [Making WordPress.org] #774: Custom field for link to slides
Making WordPress.org
noreply at wordpress.org
Mon Dec 15 21:35:51 UTC 2014
#774: Custom field for link to slides
--------------------------+------------------------------------
Reporter: BrashRebel | Owner: iandunn
Type: enhancement | Status: closed
Priority: normal | Component: WordPress.tv
Resolution: fixed | Keywords: has-patch dev-feedback
--------------------------+------------------------------------
Comment (by iandunn):
No worries, there's lots of little things that everyone encounters when
they first start contributing. The patch looks really good, though :)
Ideally we probably want to display the slides more prominently than just
appending them to the excerpt -- like maybe their own `h5` section in the
sidebar -- but since all the existing posts use the excerpt method, I
think appending the new value to the excerpt is a smart choice. The new
and old ones will match for now, and in the future we can migrate the old
date to the new field and update the design to include it.
There were a few places where the new value wasn't being escaped, so I
fixed those. We can't assume that anything pulled from the database is
safe -- even if it was validated before being put there -- since it could
have been compromised in the mean time.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/774#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list