[wp-meta] [Making WordPress.org] #610: Add post types to 'At a Glance' dashboard widget
Making WordPress.org
noreply at wordpress.org
Thu Dec 4 15:17:35 UTC 2014
#610: Add post types to 'At a Glance' dashboard widget
--------------------------+------------------------------
Reporter: hlashbrooke | Owner: iandunn
Type: enhancement | Status: accepted
Priority: low | Component: wordcamp.org
Resolution: | Keywords: has-patch commit
--------------------------+------------------------------
Changes (by kovshenin):
* keywords: has-patch => has-patch commit
Comment:
Hi there! Thanks for your patch @hlashbrooke, I refreshed it against the
current version in [attachment:610-meta.diff], also cleaned up some space
vs tabs, changed the $type vs $post_type vs $post_type_object to follow
what core uses.
And also a note about the usage of `_n()` and other localization functions
- you can't really construct strings from variables, all strings passed to
such functions should actually be strings for translation tools to pick
them up. That said, we could have used the singular and name labels for
the registered post types, however, for some languages plural has more
than one form, which means we can't. I'm pretty sure there's a core ticket
to address this, but I can't find it right now. A workaround is to use
hard-coded strings, which is what core does for posts and pages.
This patch is ready for commit, but an extra couple eyes on it won't hurt.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/610#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list