[wp-meta] [Making WordPress.org] #159: Clicking left or right sides of the Download WordPress button does nothing, or results in 404

[Making WordPress.org]

#159: Clicking left or right sides of the Download WordPress button does nothing,
or results in 404
-------------------------+---------------------
  Reporter:  rosshanney  |      Owner:
      Type:  defect      |     Status:  new
  Priority:  normal      |  Component:  General
Resolution:              |   Keywords:
-------------------------+---------------------

Comment (by SergeyBiryukov):

 Confirmed.

 "undefined" comes from `recordOutboundLink()`
 {{{
 function recordOutboundLink(link, category, action) {
         _gaq.push(['_trackEvent', category, action])
         setTimeout('document.location = "' + link.href + '"', 100);
 }
 }}}
 It's called when clicking on both the `<a>` and `<li>` tags:
 {{{
 $('#download a, .download-button').click(function() {
         recordOutboundLink(this, 'Download Links', $(this).hasClass
 ('download-button') ? 'button' : 'nav' );
         return false;
 });
 }}}
 However, it doesn't take into account that `<li>` doesn't have an `href`
 attribute.

--
Ticket URL: <http://meta.trac.wordpress.org/ticket/159#comment:1>
Making WordPress.org <http://meta.trac.wordpress.org/>
WordPress blogging software