[wp-hackers] WordPress plugin inspections

[Casey Bisson]

Harry,

Criticism is hard to take, but important for improvement.

Now that I’ve learned of your reviews, I’m anxious to find out if your team has reviewed any of my plugins, and what issues that might have uncovered.

Because I’m not the only one who has to read my code, and pull requests or patches make my day, I know I how important it is to make my code easy to read and use consistent style.

I have no idea who the reviewers are, or what their skills might be, but it’s probably fair that code that might be questionable to them is worth looking at on my part. If I’ve got a really good reason to do something that raises flags for others, then that’s a really good reason to put comments in the code explaining it. That’s especially true for security and performance issues.

Two requests:

* Consider filing bugs. Just a generic bug with a link to the review so I’d be aware of it would be great. Most of my plugins are in Github, https://github.com/misterbisson?tab=repositories (the others are sort of abandoned by now).

* If I update my plugin to address the issues, are you willing to review the updates in a reasonable time and update the public review?

Thank you,

—Casey



On Feb 19, 2014, at 10:43 AM, Harry Metcalfe <harry at dxw.com> wrote:

> Hello list,
> 
> We write and publish light-touch inspections of WordPress plugins that we do for our clients. They are just a guide - we conduct some basic checks, not a thorough review.
> 
> Would plugins which fail this inspection be of general interest to the list and therefore worth posting? Is the list also interested in vulnerability advisories, or do people tend to get those elsewhere?
> 
> Here's an example report:
> 
> https://security.dxw.com/plugins/pods-custom-content-types-and-fields/
> 
> Grateful for a steer...
> 
> Harry
> 
> 
> -- 
> Harry Metcalfe
> 07790 559 876
> @harrym
> 
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers