[wp-hackers] Upgrading to Wordpress 3.7 is deleting a file from our plugin thus breaking a lot's of sites

[John Blackbourn]

This plugin's `uninstall.php` file deletes the WP_CONTENT_DIR/themes-ai1ec
directory when called. It sounds like this plugin's uninstall.php file is
being called during the upgrade.

Potential cause: People running a plugin which forces plugin uninstall
routines to run when plugins are disabled?

@Nicola: It would help hugely if you can get a list of active plugins on
affected sites from users who are experiencing the problem.


On 26 October 2013 15:29, Nicola Peluchetti <nicola.peluchetti at gmail.com>wrote:

> Hi,
>
> sure that's horrible, we will fix that, but the real problem is that the
> file is deleted. If we catch the exception still the js is not loaded and
> the file was there before the upgrade.
> During the upgrade process, is any plugin code executed?We already have 25
> people reporting our plugin as not compatible with 3.7 for this and i
> imagine people affected are many more. I can't replicate this locally, i
> will add a check to load that file from our plugin dir and not wp-content i
> can't think of any other way to handle this.
>
> * *
> *Nicola Peluchetti - Senior PHP Developer @ Timely**
> *
> Twitter: @nik_peluchetti <https://twitter.com/#!/nik_peluchetti>
> Facebook: nicola.peluchetti <https://www.facebook.com/nicola.peluchetti>
> Stackoverflow: Stackoverflow<
> http://stackoverflow.com/users/397861/nicola-peluchetti>
> Mobile: +39 339 7507235
>
>
> On Fri, Oct 25, 2013 at 8:41 PM, Otto <otto at ottodestruct.com> wrote:
>
> > On Fri, Oct 25, 2013 at 12:18 PM, Nicola Peluchetti
> > <nicola.peluchetti at gmail.com> wrote:
> > > Hi,
> > >
> > > we received lot's of reports that our plugin is not compatible with 3.7
> > and
> > > many site where brought down. The problem seems to be that wordpress
> 3.7
> > > upgrade deletes ( in some occasions ) a file in a folder we create in
> > > wp-content.
> > > http://wordpress.org/support/topic/not-compatible-with-wp-37?replies=8
> > >
> > > The file name is event.min.js and we create the folder themes-ai1ec
> under
> > > wp-content. Any idea why this might be happening?This doesn't seem to
> be
> > > under our control but user are blaming us. If we need to change
> something
> > > to be compatible, we will, but i have no guess now on what to do.
> >
> > While I can't see any particular reason for a file like that to be
> > deleted on an update, this error is coming entirely from your plugin.
> >
> > Examine the error message posted in this thread:
> > http://wordpress.org/support/topic/not-compatible-with-wp-37?replies=8
> >
> > If you examine that code, you have this:
> >
> > if( $file_found === false ) {
> > throw new Ai1ec_File_Not_Found( "The specified file '" . $file . "'
> > doesn't exist." );
> > }
> >
> > That is a pretty horrible thing to do on a production site *if* you're
> > not catching the exception higher up and handling it gracefully. An
> > uncaught exception is a fatal error = Instantly broken site.
> >
> > I would look at all the places you're calling functions that can throw
> > Ai1ec_File_Not_Found and putting catches around them, to handle the
> > situation better.
> >
> > -Otto
> > _______________________________________________
> > wp-hackers mailing list
> > wp-hackers at lists.automattic.com
> > http://lists.automattic.com/mailman/listinfo/wp-hackers
> >
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>