[wp-hackers] comments should be a plugin

Scott Kingsley Clark sc0ttkclark at gmail.com
Sun Mar 7 04:32:55 UTC 2010


> I'm -1 on canonicalizing "Posts" and "Comments" but I am +1 on removing any hardcoded references to them in core. Again, version 3.0 decouples a lot of the default posts types (posts and pages) as well as taxonomies (cats and tags) so if you find anything that current still is hardcoded, get it reported so it can be patched.

That's definitely a good start, having them decoupled will ensure once
someone does try to disable them, nothing breaks. I'd preferably like
to see the post-specific / page-specific / link-specific / comment-
specific code in a Canonical plugin OR option internally. Plugins can
do a lot, but bloat should be able to be managed from within the box
(lumped altogether as one big bloat) and not requiring extra bloat to
remove the bloat - if that makes sense ;)

> As an example right now WordPress 3.0 has 5 "core" post types: post, page, attachment, revision and nav_menu_item.  It's currently architected to assume they are there which means that, for example, if I were to remove the "post" type I create undefined conditions such as a "Posts" menu that has "Add New" and that errors out when I try to add one.

Am I the only one that is confused as to why nav_menu_item is in
wp_posts? Maybe I should look into trunk and see why ;)

BTW, (not to sidetrack the thread entirely) the wp_posts+postmeta vs
wp_comments+commentmeta is a good example of why Custom Post Types
aren't always best solution (vs custom tables). Finally, proof that
the core team agrees (somewhat)! Comments aren't Posts, and so aren't
a ton of other things :-) okay.. /end hijacking


-Scott


On Mar 6, 10:17 pm, Ptah Dunbar <p... at ptahd.com> wrote:
> > As an example right now WordPress 3.0 has 5 "core" post types: post, page, attachment, revision and nav_menu_item.  It's currently architected to assume they are there which means that, for example, if I were to remove the "post" type I create undefined conditions such as a "Posts" menu that has "Add New" and that errors out when I try to add one.
>
> I raised that issue about core post types not using the show_ui argument so if one decides to remove them, Posts,  Pages, and Media would disappear from the UI. Outside of that, I disagree that the core post types are really that hardcoded into WP; and if so, then that's probably a bug which you should file a new ticket for.
>
> > By having (previously) "core" functionality like "Posts" and "Comments" in canonical plugins those broken edge cases are much more likely to be worked out by the core dev team instead of individually by everyone who needs it and has the resources to work on it.
>
> I'm -1 on canonicalizing "Posts" and "Comments" but I am +1 on removing any hardcoded references to them in core. Again, version 3.0 decouples a lot of the default posts types (posts and pages) as well as taxonomies (cats and tags) so if you find anything that current still is hardcoded, get it reported so it can be patched.
>
> - Ptah Dunbar
> _______________________________________________
> wp-hackers mailing list
> wp-hack... at lists.automattic.comhttp://lists.automattic.com/mailman/listinfo/wp-hackers


More information about the wp-hackers mailing list