[wp-hackers] theme-based functions.php should override pluggable-functions.php

[Robert Deaton]

On 2/18/06, Aaron Brazell <aaron at technosailor.com> wrote:
> On 2/18/06, Andy Skelton <skeltoac at gmail.com> wrote:
> >
> > On 2/18/06, Aaron Brazell <aaron at technosailor.com> wrote:
> > > Don't you think?
> > >
> > > Ticket #2479 <http://trac.wordpress.org/ticket/2479#preview> in Trac.
> >
> > I don't think so. {theme}/functions.php is not a plugin. It should not
> > be treated as one.
> >
> > There are many differences between a theme's functions file and a
> > plugin. Let's keep it that way.
> >
> > Andy
> >
>
> I know what you're saying and I am not saying {theme}/functions.php is a
> plugin.  But it is user-designated and in my opinion, if a user is given
> veto power over pluggable-functions.php via a plugin, he should be given it
> the other way as well.
>
> I do agree there's differences between functions.php and plugins (for
> instance the added layer of protection from activation being required) --
> but then I'm talking about overriding pluggable-functions, not critical
> functionality.

Overriding pluggable-functions is critical functionality, login,
cookies, userdata, admin redirection, things that a theme should never
worry about. I can't think of anything that a theme would need to do
that would require you to change the whole user or authorization
portions of the code.

Not to mention the number of themes we would potentially break because
they assume that these functions are defined, notably
get_currentuserinfo.

--
--Robert Deaton
http://somethingunpredictable.com