[wp-hackers] Bizarre /cache/ experience with wp_object_cache.lock

[Mark Jaquith]

On Feb 4, 2006, at 12:41 AM, Jamie Talbot wrote:

> Mark Jaquith wrote:
>
>> Lines 407 and 408 are redundant... we don't need to bother checking
>> safe mode if we're already disabling it by default
>
> We should still disable it for people who turn it on even though  
> they are in safe mode, shouldn't we?

Absolutely not!  As Ryan has said before, safe mode doesn't mean that  
it won't work... there exist "functional" safe mode setups.

And at any rate, that's now what those lines do.  Those lines disable  
the cache if the user is using safe mode and has not specified  
ENABLE_CACHE ... but we're already disabling the cache if the user  
hasn't specified ENABLE_CACHE, so it's pointless to have those  
lines.  The if() condition will never be true, because the lines  
before it would return before they'd even get executed.

--
Mark Jaquith
http://txfx.net/