[theme-reviewers] Proper use of pre_get_posts callback

priyanshu mittal priyanshu.mittal at gmail.com
Tue Sep 30 08:12:45 UTC 2014


I am reviewing a theme.

In this theme developer used a slider and masonary layout from the
index.php file.

He used sticky posts to make up the slider:- for this the seperate wp_query
object is called and properly resetted via wp_reset_postdata function.

In the masonry layout of posts in order to use his own custom pagination
function, he used query_posts, to alter the core loop, I know this is not
the correct way to do it.

My point is should I ask him to create new wp_query object for this or
should I advice him to use pre_get_posts function.

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140930/489009a9/attachment.html>


More information about the theme-reviewers mailing list