[theme-reviewers] Custom pagination acceptable or not?

Sun Sep 14 17:46:58 UTC 2014

They're using core functions to create their own pagination function ...
nothing wrong with that.

Feel free to suggest a better method to accomplish what they are trying to
do if you think there is a better way of doing it.

Edward Caissie
aka Cais.

On Sun, Sep 14, 2014 at 1:05 PM, Weblizar WordPress Premium Themes And
Plugins <lizarweb at gmail.com> wrote:

> One the Experience Admin had told me that WPORG core function must be used
> for pagination and navigation.
>
> So I just asked.
>
> *Kindest Regards*
>
> *Weblizar*
> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>
> On Sun, Sep 14, 2014 at 10:28 PM, Edward Caissie <edward.caissie at gmail.com
> > wrote:
>
>> It's not so much if the code is OK, it's more a question of why do you
>> think it is not OK?
>>
>> This is important to understand from your review, why are you questioning
>> if there is a problem ... what part of the code is causing you to be
>> concerned?
>>
>>
>> Edward Caissie
>> aka Cais.
>>
>> On Sun, Sep 14, 2014 at 12:49 PM, Weblizar WordPress Premium Themes And
>> Plugins <lizarweb at gmail.com> wrote:
>>
>>> Yes, Is this ok to have this in the theme ?
>>>
>>> *Kindest Regards*
>>>
>>> *Weblizar*
>>> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
>>> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
>>> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
>>> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
>>> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>>>
>>> On Sun, Sep 14, 2014 at 10:14 PM, Edward Caissie <
>>> edward.caissie at gmail.com> wrote:
>>>
>>>> Yes, I saw the paste bin link and quickly looked at the code ... what
>>>> concerns do you have with it that makes you think it should not be used?
>>>>
>>>> Edward Caissie
>>>> aka Cais.
>>>>
>>>> On Sun, Sep 14, 2014 at 12:24 PM, Weblizar WordPress Premium Themes And
>>>> Plugins <lizarweb at gmail.com> wrote:
>>>>
>>>>> Code has the link of paste bin.
>>>>>
>>>>> and the actual php custom pagination code is there, which is used in a
>>>>> theme,I'm reviewing.
>>>>>
>>>>> *Kindest Regards*
>>>>>
>>>>> *Weblizar*
>>>>> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
>>>>> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
>>>>> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
>>>>> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
>>>>> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>>>>>
>>>>> On Sun, Sep 14, 2014 at 9:50 PM, Edward Caissie <
>>>>> edward.caissie at gmail.com> wrote:
>>>>>
>>>>>> What are your concerns with the code?
>>>>>>
>>>>>>
>>>>>> Edward Caissie
>>>>>> aka Cais.
>>>>>>
>>>>>> On Sun, Sep 14, 2014 at 5:59 AM, Weblizar WordPress Premium Themes
>>>>>> And Plugins <lizarweb at gmail.com> wrote:
>>>>>>
>>>>>>> Reviewing a Theme . Is this allow in theme ?
>>>>>>>
>>>>>>> Code <http://tny.cz/5c93d218>
>>>>>>>
>>>>>>> *Kindest Regards*
>>>>>>>
>>>>>>> *Weblizar*
>>>>>>> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
>>>>>>> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
>>>>>>> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
>>>>>>> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
>>>>>>> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>>>>>>>
>>>>>>> On Sat, Sep 13, 2014 at 7:34 PM, Weblizar WordPress Premium Themes
>>>>>>> And Plugins <lizarweb at gmail.com> wrote:
>>>>>>>
>>>>>>>> Thanks all for the Guide me.
>>>>>>>>
>>>>>>>> *Kindest Regards*
>>>>>>>>
>>>>>>>> *Weblizar*
>>>>>>>> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
>>>>>>>> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
>>>>>>>> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
>>>>>>>> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
>>>>>>>> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>>>>>>>>
>>>>>>>> On Sat, Sep 13, 2014 at 6:52 PM, Harish <me at harishchouhan.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Check TwentyFourteen theme. It uses the pagination.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Harish
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *From:* theme-reviewers [mailto:
>>>>>>>>> theme-reviewers-bounces at lists.wordpress.org] *On Behalf Of *Justin
>>>>>>>>> Tadlock
>>>>>>>>> *Sent:* Sat 13 September 14 06:48 PM
>>>>>>>>>
>>>>>>>>> *To:* Discussion list for WordPress theme reviewers.
>>>>>>>>> *Subject:* Re: [theme-reviewers] Custom pagination acceptable or
>>>>>>>>> not?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> You can definitely have custom pagination in your theme.  This is
>>>>>>>>> one of those things that falls under "presentational" in nature, so it's OK
>>>>>>>>> to have it in your theme.  You must make use of core functionality though,
>>>>>>>>> which means using `paginate_links()`.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, Sep 13, 2014 at 7:53 AM, Srikanth Koneru <tskk79 at gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> you can have <prev 1 2 3 next> using core function example is at
>>>>>>>>> http://codex.wordpress.org/Function_Reference/paginate_links
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, Sep 13, 2014 at 6:18 PM, FasterThemes Support <
>>>>>>>>> support at fasterthemes.com> wrote:
>>>>>>>>>
>>>>>>>>> +1 to Stanko Metodiev.
>>>>>>>>> A good solution ! :)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *From:* theme-reviewers [mailto:
>>>>>>>>> theme-reviewers-bounces at lists.wordpress.org] *On Behalf Of *Stanko
>>>>>>>>> Metodiev
>>>>>>>>> *Sent:* 13 September, 2014 6:16 PM
>>>>>>>>> *To:* Discussion list for WordPress theme reviewers.
>>>>>>>>> *Subject:* Re: [theme-reviewers] Custom pagination acceptable or
>>>>>>>>> not?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> You could add support for some of the existing pagination plugins,
>>>>>>>>> e.g. https://wordpress.org/plugins/wp-pagenavi/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 13 September 2014 15:42, FasterThemes Support <
>>>>>>>>> support at fasterthemes.com> wrote:
>>>>>>>>>
>>>>>>>>> I don't think so. It falls in plugin territory !
>>>>>>>>> Solution is : create 1 plugin and once approved in WP.org ,
>>>>>>>>> recommend it to your theme users through TGM.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *From:* theme-reviewers [mailto:
>>>>>>>>> theme-reviewers-bounces at lists.wordpress.org] *On Behalf Of *Weblizar
>>>>>>>>> WordPress Premium Themes And Plugins
>>>>>>>>> *Sent:* 13 September, 2014 6:08 PM
>>>>>>>>> *To:* Discussion list for WordPress theme reviewers.
>>>>>>>>> *Subject:* [theme-reviewers] Custom pagination acceptable or not?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Can I use customise Pagination in my next WordPress Theme?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *Kindest Regards*
>>>>>>>>>
>>>>>>>>> *Weblizar*
>>>>>>>>>
>>>>>>>>> *Follow Us: Twitter <https://twitter.com/weblizar> | Facebook
>>>>>>>>> <https://www.facebook.com/pages/Weblizar/1440510482872657> | Google+
>>>>>>>>> <https://plus.google.com/u/0/100920322672659513870/> | Linkedin
>>>>>>>>> <http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460>*
>>>>>>>>> | *Pinterest <http://www.pinterest.com/lizarweb/>*
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>> Stanko Metodiev,
>>>>>>>>>
>>>>>>>>> WordPress Developer
>>>>>>>>>
>>>>>>>>> @metodiew
>>>>>>>>>
>>>>>>>>> http://metodiew.com/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140914/e0dd1088/attachment-0001.html>