[theme-reviewers] Bug with Theme Check

[Konstantin Kovshenin]

https://github.com/Otto42/theme-check/pull/1

On Sun, Oct 26, 2014 at 5:09 PM, Otto <otto at ottodestruct.com> wrote:

> If you have a patch for the regex which can eliminate this, be sure to
> email me about it. Happy to make adjustments. :)
>
>
> -Otto
>
> On Sun, Oct 26, 2014 at 6:44 PM, Alex Vasquez <alexjvas at gmail.com> wrote:
>
>> Hey folks.
>> Found an issue with the theme check plugin.
>>
>> Seems there's an issue on line 21 of 'theme-check/checks/customizer.php'.
>>
>> The issue that occurs is if your default value has a semi-colon, the
>> sanitize_callback function, which uses regex pattern matching, will stop
>> matching when it encounters the semi-colon in the default value. A work
>> around for this is to put the  order of the sanitize_callback before the
>> default value.
>>
>> Big ups to Konstantin Kovshenin for finding the bug and workaround.
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
Konstantin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141028/7a2bf0e8/attachment.html>