[theme-reviewers] Redux framework may be dialing home

[Emil Uzelac]

Absolutely!

On Thu, Oct 16, 2014 at 1:13 PM, Edward Caissie <edward.caissie at gmail.com>
wrote:

> Well, I think this example goes to the point it should not be allowed,
> period.
>
> Edward Caissie
> aka Cais.
>
> On Thu, Oct 16, 2014 at 2:11 PM, Emil Uzelac <emil at uzelac.me> wrote:
>
>> We actually said yes to this in 2012 I believe, but only for the author,
>> not the framework.
>>
>> On Thu, Oct 16, 2014 at 1:09 PM, Edward Caissie <edward.caissie at gmail.com
>> > wrote:
>>
>>> What was the reasoning used to allow call-home code, with opt-in or not?
>>>
>>> Edward Caissie
>>> aka Cais.
>>>
>>> On Thu, Oct 16, 2014 at 2:05 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> ​Hi Kelly,
>>>>
>>>> If this theme is not released by Redux itself, no tracking is allowed,
>>>> regardless of how they are set. We allow some types, but they must be
>>>> opt-in only and tied directly with the author of the theme, not third-party.
>>>>
>>>> All other themes with Redux in it will have to remove the trackers.
>>>>
>>>> Thanks,
>>>> Emil​
>>>>
>>>> On Thu, Oct 16, 2014 at 12:55 PM, Kelly Dwan <
>>>> kelly.dwan+themes at gmail.com> wrote:
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> I noticed an issue with the Redux framework while reviewing. It
>>>>> appears to be "dialing home", sending system and install info back to
>>>>> https://redux-tracking.herokuapp.com. I think it's sending this data
>>>>> even if you've opted-out, due to a loose comparison: allow_tracking is set
>>>>> to "yes" or "no" when you dismiss the "can we track you" pointer, and later
>>>>> it checks "yes" or "no" against true
>>>>> <https://github.com/ReduxFramework/redux-framework/blob/master/ReduxCore/inc/tracking.php#L95>,
>>>>> which evals to true, and sets up tracking.
>>>>>
>>>>> In addition to the theme I'm reviewing, there are other themes already
>>>>> approved that use this framework, and seem to be doing the same thing.
>>>>>
>>>>> --Kelly
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141016/4d9d0ef0/attachment.html>