[theme-reviewers] Modifying Default Gallery

[Emil Uzelac]

See https://themes.svn.wordpress.org/alexis/1.2.0/functions.php I can
easily be wrong :) Just don't remember that we allowed this before.

On Tue, Oct 7, 2014 at 7:35 PM, Justin Tadlock <justin at justintadlock.com>
wrote:

> As long as the user can use the core parameters, there shouldn't be any
> issues.  Filtering the gallery shortcode output is one area that, at least
> to me, falls clearly in theme territory since we're referring to the
> presentational aspect of content.
>
> Of course, plugins could perform the same function, but for that matter,
> plugins could perform any function you can do in a theme.
>
> On Tue, Oct 7, 2014 at 6:25 PM, Emil Uzelac <emil at uzelac.me> wrote:
>
>> My understanding was that theme overrides core, if so it is not accepted.
>> Extending, sure :) User should be able to use core features.
>>
>> On Tue, Oct 7, 2014 at 6:21 PM, Otto <otto at ottodestruct.com> wrote:
>>
>>> I dunno, actually. It is an interesting question. How galleries display
>>> is part of the visual style of the theme. I don't see anything wrong with
>>> including masonry-enabled galleries in the theme, especially as some kind
>>> of optional thing.
>>>
>>> Now, I would suggest to the theme author not to override the gallery
>>> shortcode itself, but to use the post_gallery filter instead, which will
>>> let them do essentially the same thing without tinkering with "shortcodes".
>>>
>>> That said, you would want to make sure that the controls for galleries
>>> in WordPress still operate as you would expect them to, more or less.
>>> Obviously, something like masonry is probably going to change the meaning
>>> of "columns" and the like, but still, that should be mostly functional, to
>>> whatever extent makes sense.
>>>
>>> But then again, anything you do here in a theme could be done in a
>>> plugin too, and said plugin could be made universal for any theme, so
>>> unless this particular gallery shortcode is deeply tied to the theme in
>>> some way, then it's probably better in a plugin.
>>>
>>>
>>> -Otto
>>>
>>> On Tue, Oct 7, 2014 at 6:18 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> Not silly at all :)
>>>>
>>>> This would definitely fall under plugins. ​
>>>>
>>>> On Tue, Oct 7, 2014 at 6:11 PM, Ryan Cowles <ryan.cowles at automattic.com
>>>> > wrote:
>>>>
>>>>> Howdy,
>>>>>
>>>>> I'm reviewing a theme that overwrites the native gallery shortcode
>>>>> with a custom Masonry gallery. Seems like a silly question, but I'm looking
>>>>> for confirmation - would this fall under plugin territory?
>>>>>
>>>>> Thanks!
>>>>> Ryan
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141007/0724c2d0/attachment.html>