[theme-reviewers] Theme Review Question - finding errors

[Liane Blanco]

Okay, we're not on the same page. Literally. This is where I've been
looking:

https://make.wordpress.org/docs/theme-developer-handbook/part-four-releasing-your-theme/theme-review-guidelines/#code-quality

which says:

"Themes must not generate any WordPress deprecated-function notices, PHP
errors, warnings, or notices, *HTML/CSS validation errors*, or JavaScript
errors."

I was looking in the theme developer handbook, not the theme reviewer
handbook. Rohit, my apologies for contradicting you! :(

On Sat, Oct 4, 2014 at 1:19 AM, Ulrich Pogson <grapplerulrich at gmail.com>
wrote:

> "Themes must not have any notices, warnings, or errors." This is under the
> section of PHP, CSS, JS and HTML.
>
>
> https://make.wordpress.org/themes/handbook/guidelines/code-quality/#php-js-css-html
>
> But validation is not needed as vendor specific css would not pass.
>
> On 4 October 2014 10:16, Rohit Tripathi <rohitink at live.com> wrote:
>
>> I am the mentor for Liane. And as far as I know, HTML/CSS validation is
>> not required. But, it's good to get it confirmed once more.
>>
>> Sent from my iPhone
>>
>> On 04-Oct-2014, at 1:32 pm, Liane Blanco <lianeblanco at gmail.com> wrote:
>>
>> While we're on the subject of errors, the Theme Guidelines do state that
>> there should be no HTML/CSS errors. Does this still apply? I discussed with
>> my mentor, who said that he was told that it was not important. So should
>> that not be removed from the guidelines?
>>
>>
>>
>> On Sat, Oct 4, 2014 at 12:42 AM, Emil Uzelac <emil at uzelac.me> wrote:
>>
>>> Anytime you have the issue like that please Cc me directly in the ticket
>>> and I will resolve the problem :)
>>>
>>>
>>> On Saturday, October 4, 2014, Liane Blanco <lianeblanco at gmail.com>
>>> wrote:
>>>
>>>> Yep, I figured it was something like that. :)
>>>>
>>>> On Sat, Oct 4, 2014 at 12:37 AM, Jose Castaneda <jomcastaneda at gmail.com
>>>> > wrote:
>>>>
>>>>> It was recently updated so if any themes were uploaded prior to that
>>>>> weren't caught. :)
>>>>>
>>>>>
>>>>>
>>>>> On Oct 4, 2014, at 12:11 AM, Liane Blanco <lianeblanco at gmail.com>
>>>>> wrote:
>>>>>
>>>>> It must not have, or something changed between the time the theme was
>>>>> uploaded, because I had two errors about screen_icon being deprecated since
>>>>> 3.8, and a lot of recommends. I pasted these for the theme author, and also
>>>>> linked to the validation results for his CSS stylesheet (there were 40
>>>>> errors) and he got angry and said he wanted another reviewer. Kind of
>>>>> disconcerting...
>>>>>
>>>>> Anyway, live and learn. I will go over each file more carefully in
>>>>> future. Should I just not tell the author in future that there are
>>>>> recommends from the Theme Check?
>>>>>
>>>>> On Fri, Oct 3, 2014 at 11:51 PM, <tskk79 at gmail.com> wrote:
>>>>>
>>>>>> You should do both, run themecheck and go line by line, but if there
>>>>>> are any required issues by themecheck, theme upload will fail anyway.
>>>>>> Sent from BlackBerry® on Airtel
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Liane Blanco <lianeblanco at gmail.com>
>>>>>> Sender: "theme-reviewers" <
>>>>>> theme-reviewers-bounces at lists.wordpress.org>Date: Fri, 3 Oct 2014
>>>>>> 23:48:03
>>>>>> To: Discussion list for WordPress theme reviewers.<
>>>>>> theme-reviewers at lists.wordpress.org>
>>>>>> Reply-To: "Discussion list for WordPress theme reviewers."
>>>>>>  <theme-reviewers at lists.wordpress.org>
>>>>>> Subject: Re: [theme-reviewers] Theme Review Question - finding errors
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Insert clever phrase here
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Insert clever phrase here
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> Insert clever phrase here
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
Insert clever phrase here
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141004/79e244b9/attachment.html>