[theme-reviewers] Redux Framework

[Ulrich Pogson]

Thanks! :)


On 23 March 2014 22:58, Otto <otto at ottodestruct.com> wrote:

> On Sun, Mar 23, 2014 at 2:06 PM, Ulrich Pogson <grapplerulrich at gmail.com>wrote:
>
>> Redux Framework uses add_submenu_page() instead of add_theme_page(). Can
>> we make an exception here if the the added menu item is under "Appearance"?
>>
>
> No, because that is what add_theme_page is for.
>
> The add_theme_page function is just a wrapper for add_submenu_page that
> automatically puts in the "themes.php" name for the first parameter.
>
> So, if at some future point, the files get a renaming or the menu system
> gets a big heavy reorganization, then themes using add_theme_page would not
> need any changes to continue working properly.
>
> When high level wrappers exist for this sort of thing, then plugin/theme
> code should use them for maximum future compatibility.
>
> -Otto
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140323/e58bfae0/attachment.html>