[theme-reviewers] Redux Framework

[Chip Bennett]

What's the rationale for the exception?

The correct function for adding a submenu page to the Appearance menu is
add_theme_page(). This is also something that, as far as I know, is flagged
by both Theme Check and the uploader script.


On Sun, Mar 23, 2014 at 4:40 PM, Ulrich Pogson <grapplerulrich at gmail.com>wrote:

> @Emil - My question was "Can we make an *exception *here if the added
> menu item is under "Appearance"?" :)
>
> The guidelines is clear to me but do we need to be so strict if a similar
> function gets the same result.
>
> *If* the guideline was this then there would be no problem.
> "Themes are *required* to add the Theme Settings Page to the *Appearance*
>  menu"
>
>
> On 23 March 2014 21:10, Emil Uzelac <emil at uzelac.me> wrote:
>
>> The requirement is pretty much self explanatory ;-)
>> On Mar 23, 2014 2:09 PM, "WordPress (thinkupthemes)" <
>> wordpress at thinkupthemes.com> wrote:
>>
>>> Redux is very easy to customize. You can edit the relevant code in
>>> framework.php to make it compliment. That's what we do.
>>>
>>> Afzaal
>>>
>>> Sent from my iPhone
>>>
>>> On 23 Mar 2014, at 19:06, Ulrich Pogson <grapplerulrich at gmail.com>
>>> wrote:
>>>
>>> Redux Framework uses add_submenu_page() instead of add_theme_page(). Can
>>> we make an exception here if the the added menu item is under "Appearance"?
>>>
>>> "Themes are *required* to use the *add_theme_page()* function to add
>>> the Theme Settings Page to the *Appearance* menu"
>>>
>>> http://make.wordpress.org/themes/guidelines/guidelines-theme-security-and-privacy/
>>>
>>>
>>> https://github.com/ReduxFramework/redux-framework/search?q=add_submenu_page
>>>
>>> Thanks
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140323/71a1ada2/attachment-0001.html>