[theme-reviewers] Options Tree Framework: Group Review Project

[Dylan Scott]

Well I would definitely be interested :) - Although my time seems to be
split into a million different ways at the moment


On 25 June 2014 17:14, Dylan Scott <dylanrhysscott at gmail.com> wrote:

> Well I would definitely be interested :) - Although my time seems to be
> split into a million different ways at the moment
>
> Dylan
>
>
> On 25 June 2014 17:09, Chip Bennett <chip at chipbennett.net> wrote:
>
>> That's part of why I thought this exercise might be helpful. :)
>>
>>
>> On Wed, Jun 25, 2014 at 11:01 AM, Dylan Scott <
>> dylan.scott at webunitydesign.com> wrote:
>>
>>> Hi Chip,
>>>
>>> After some of the reviews I've done I've found options frameworks a bit
>>> infuriating to review as everything seems to be buried and difficult to
>>> find. Has anyone else found this? Or I am just new to the process and way
>>> of thinking with a framework?
>>>
>>> Kind Regards
>>>
>>>
>>>
>>> On 25 June 2014 15:28, Chip Bennett <chip at chipbennett.net> wrote:
>>>
>>>> I think the ThemeForest-sponsored Options Tree framework (
>>>> https://github.com/valendesigns/option-tree ) needs a detailed
>>>> vetting, as I'm seeing it used in several Themes, and note at least two
>>>> issues:
>>>>
>>>> 1. Saving default settings to the database (not using sane defaults)
>>>> 2. Multiple wp_options entries (multiple register_setting() and
>>>> update_option() calls, based on single-setting ID)
>>>>
>>>> I don't have time at the moment to go through the framework at the
>>>> level of detail needed (doing the best I can, just to keep the approval
>>>> queue in reasonable shape), so I thought it might be a good idea to make a
>>>> group project out of it. Anyone who wants to practice reviewing an options
>>>> framework, and who has time to contribute, please dig through it, and post
>>>> any comments here.
>>>>
>>>> The purpose here is two-fold: to review this specific framework, and
>>>> also to provide an opportunity for new reviewers for whom review of such
>>>> code might seem daunting. So, let's see how it goes!
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140625/3d9ed69f/attachment-0001.html>