[theme-reviewers] jQuery Isotope

[Imon Themes]

Hi,
as new theme reviewer . i have question for  @Emil Uzelac  @Chip Bennett

i find issue in a theme . which is i currently reviewing . theme ticket is
https://themes.trac.wordpress.org/ticket/18902

in this theme he use :

/*add meta_box*/
 function cybergames_add_metabox_for_slider() {
add_meta_box( 'metabox_slider_id', 'Slider Post',
'cybergames_metabox_callback', 'post', 'side' );
}

/*callback function for meta box*/
function cybergames_metabox_callback() {
global $post;
$screen = get_current_screen(); ?>
<input type='checkbox' name='cbg_add_to_slider' id='cbg_add_to_slider'
value='on' <?php if ( 'on' == get_post_meta( $post->ID,
'cbg_add_to_slider', true ) ) { ?> checked='checked' <?php } ?> />
<label for='cbg_add_to_slider'><?php echo '&nbsp'. __( 'Display this',
'cybergames' ) .'&nbsp' . $screen->post_type . '&nbsp'. __( 'in slider',
'cybergames' ); ?></label>
<?php }


He use add meta box code . this code is acceptable or not ?

thanks



On Sat, May 31, 2014 at 8:22 PM, Emil Uzelac <emil at uzelac.me> wrote:

> great example :)
>
>
> On Saturday, May 31, 2014, Chip Bennett <chip at chipbennett.net> wrote:
>
>> Right, here's the scenario that demonstrates the issue:
>>
>> Developer A releases a free Theme that bundles the GPL3-licensed jQuery
>> Isotope. Developer B takes Theme A, and uses it to create a derivative
>> work, Theme B. Developer B then decides to sell Theme B.
>>
>> According to the license terms of jQuery Isotope, Developer B must then
>> purchase a commercial license (i.e. pay a fee) for an ostensibly
>> GPL3-licensed library that came as part of Theme A.
>>
>> That's not compatible with GPL.
>>
>>
>> On Sat, May 31, 2014 at 10:19 AM, Emil Uzelac <emil at uzelac.me> wrote:
>>
>>> we discussed before terms are no good there, therefore not compatible
>>>
>>>
>>> On Saturday, May 31, 2014, Justin Tadlock <justin at justintadlock.com>
>>> wrote:
>>>
>>>> Isotope is released under two licenses, one is the GPL v3 in open
>>>> source project. The other is a commercial license.
>>>> https://github.com/metafizzy/isotope
>>>>
>>>>
>>>>
>>>>
>>>> On Sat, May 31, 2014 at 8:44 AM, Emil Uzelac <emil at uzelac.me> wrote:
>>>>
>>>>> thanks
>>>>>
>>>>>
>>>>> On Saturday, May 31, 2014, Gary Barrett <gary at headwaythemes.com>
>>>>> wrote:
>>>>>
>>>>>> Hi everyone,
>>>>>>
>>>>>> A theme called 'Bearded' is on the repo and is currently a featured theme. It contains jQuery Isotope, which
>>>>>> is released under a non-GPL compatible license.
>>>>>>
>>>>>> The theme - http://wordpress.org/themes/bearded <https://themes.trac.wordpress.org/ticket/16610>
>>>>>>
>>>>>> The script -http://themes.svn.wordpress.org/bearded/1.0.4/assets/js/libs/jquery.isotope.min.js <http://themes.svn.wordpress.org/sampression-lite/1.4.1.1/lib/js/jquery.isotope.min.js>
>>>>>>
>>>>>> Regards,
>>>>>> Gary
>>>>>>
>>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
*Imon Themes*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140604/902affa1/attachment.html>