[theme-reviewers] Going around the Settings API

[ethan anwar]

Hi and sorry to bother you all again!

I'm reviewing another theme ( https://themes.trac.wordpress.org/ticket/15946 ) and I have noticed what I consider blurry use of the Theme Settings API. 


Basically the theme's developer uses all the right functions, registers the main settings array via register_setting() but doesn't add any settings via add_settings_field(). Then, inside the function for the actual options page he uses settings_fields() then
do_settings_sections() which probably don't return anything. After this, HTML follows with the actual code for the settings.

What's your opinion on this? Shouldn't he use add_settings_section() and add_settings_field() if he's going with do_settings_sections() and settings_fields() ?

As always thanks a lot for your time guys!

Kay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140118/34737e0e/attachment.html>