[theme-reviewers] Plugins within Themes

[Ulrich Pogson]

@Edward That makes sense. I already did the test that you recommended for Drag
& Drop Featured Image and it worked fine.

if these plugins are integrated into the theme then as far as I am
> concerned they should also be properly name-spaced for the specific theme
> as well


I suppose a test to check if the plugin was being loaded from a different
place before loading the version in the theme would work too. Using
something like is_class() or is_function().


On 4 January 2014 00:33, Edward Caissie <edward.caissie at gmail.com> wrote:

> Although I will leave the theme ticket concerns as is, my initial thoughts
> on integrating the listed plugins are respectively:
>
> WP LESS to CSS - although by the theme author, it would depend on how it
> is integrated but essentially as a plugin it is probably still best, if the
> author wants to provide code that enhances the theme when his plugin is
> also active then that is not an issue.
>
> Options Framework - I do not really have too much issue with this being
> integrated, provided it is properly attributed to the plugin author ... I
> look at this as more along the lines of "why re-invent the wheel"?
>
> Drag & Drop Featured Image - Great plugin idea and nice enhancement to
> most any theme, as long as it does not affect the core Featured Image
> functionality (test by using the drag and drop then switch themes to ensure
> the Feature Image is retained) I do not have an issue with this being
> integrated into the theme with proper attribution as well.
>
> Also to note, if these plugins are integrated into the theme then as far
> as I am concerned they should also be properly name-spaced for the specific
> theme as well ... they should be properly maintained *and enhanced* at
> the hand of the theme author going forward. Otherwise, why integrate the
> plugins ... why not just write respective theme enhancement code in their
> place?
>
>
>
> Edward Caissie
> aka Cais.
>
>
> On Fri, Jan 3, 2014 at 5:42 PM, Ulrich Pogson <grapplerulrich at gmail.com>wrote:
>
>> Are themes allowed to have plugin integrated in the themes?
>>
>> I have looked at the functionality that is not allowed and these plugins
>> would not dong this functionality.
>>
>>  http://make.wordpress.org/themes/guidelines/guidelines-plugin-territory/
>>
>> I am reviewing the theme: https://themes.trac.wordpress.org/ticket/15869
>>
>> There are three plugins integrated in it are
>> http://wordpress.org/plugins/wp-less-to-css/
>> http://wordpress.org/plugins/options-framework/
>> http://wordpress.org/plugins/drag-drop-featured-image/
>>
>> Are these allowed or not?
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140104/30d6131f/attachment-0001.html>