[theme-reviewers] Can Text Domain be name of the Theme shop?

[Ulrich Pogson]

@Mel If you change the text domain nothing will break. The text domain for
themes is not defined in the po or mo files. It is defined in the i18n
functions, functions.php and the header in styles.css.

The only place it could break is if someone has a translation in the
WordPress language directory. Support for it was included in WP 3.7.

Ulrich


On 6 February 2014 17:22, esmi at quirm dot net <esmi at quirm.net> wrote:

> on 06/02/2014 14:26 Chip Bennett said the following:
>
>  If the textdomain is unique, but not a literal string-match for theme-slug
>> - if that's the only issue preventing approval, I would not hold up
>> approval just for that. It will be required eventually, but right now, is
>> completely invisible to the end user.
>>
>
> Question - possibly for discussion...
>
> I have themes hosted @ WPORG since before the theme review guidelines came
> in. One of those themes has the theme slug 'purple-pastels' but the
> textdomain has always been (& is still) 'purplepastels'.
>
> Now I'd happily change all textdomain occurrences the next time I update
> the theme (it would take less than a minute to do) but what about existing
> users who might be relying on the old textdomain? This theme has been
> around for a while and I know that there have been quite a few .pot
> translation files created over the years.
>
> So - what's the lesser of two evils here? Continue to knowingly breach the
> guidelines on this point or potentially break some user sites? I'd imagine
> that I'm not the only one who has this quandary.
>
> Mel
> --
> http://quirm.net
> http://blackwidows.co.uk
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140206/97efb97d/attachment.html>