[theme-reviewers] flaw in gallery CSS

[Styled Themes]

Doesn't work in the default themes either.test it with the small thumbnails.

 

From: theme-reviewers [mailto:theme-reviewers-bounces at lists.wordpress.org]
On Behalf Of Amirmasoud Sheidayi
Sent: August-09-14 5:39 PM
To: Discussion list for WordPress theme reviewers.
Subject: Re: [theme-reviewers] flaw in gallery CSS

 

they will align with calc or -webkit-calc in your theme style. You can check
this in wordpress default themes, so you should expect it from modern
browsers and chrome. That's what I got from gallary in wordpress. :) 

On Aug 9, 2014 1:52 AM, "Styled Themes" <social at styledthemes.com> wrote:

Haha. Good to know Chip. I didn't want someone to see that the 4-column is
actually not 4 columns, 5 is not 5 columns, etc., unless they change the
thumbnail size. But it sounds like this will be OK.

 

From: theme-reviewers [mailto:theme-reviewers-bounces at lists.wordpress.org]
On Behalf Of Chip Bennett
Sent: August-08-14 2:15 PM
To: Discussion list for WordPress theme reviewers.
Subject: Re: [theme-reviewers] flaw in gallery CSS

 

Issues with core-defined gallery CSS will *not* affect review/approval of
your Theme, since your Theme isn't defining the CSS. And even if the Theme
were filtering the core-defined gallery CSS, any related issues would only
be noted as *recommended* in the review.

 

On Fri, Aug 8, 2014 at 4:06 PM, Styled Themes <social at styledthemes.com>
wrote:

Before I submit my new theme, I discovered something when testing the theme
with the theme unit test, in particular, the gallery when using the
thumbnail size (default). When you view a 4 or more column gallery, they do
not float correctly and it's basically a continuous row of thumbnails until
it reaches the edge of the content area, then it continues to the next line.
This also happens with the Twenty Thirteen and Twenty Fourteen themes. This
is when the inline styling for the gallery is removed (as it is coded even
for the default themes now), but it appears there is a flaw in the gallery
layout CSS. It works fine when the thumbnail size is set to at least medium.

 

With my theme I'm about to submit, I simply used the same CSS as the default
WP theme Twenty Fourteen that uses <figure> and no inline styling..but as I
mentioned, the column CSS for the gallery is flawed and does not properly
wrap to the next line. I'm assuming this is going to affect the review and
approval of my theme?


_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

 


_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140809/6284a6df/attachment.html>