[theme-reviewers] Best Practice Question: style.css

[Justin Tadlock]

I always load both the parent and child theme style.css.  Since I've
started doing this, questions related to loading the parent theme
stylesheet in a child theme are pretty much nonexistent.


On Fri, Aug 1, 2014 at 1:14 PM, Sami Keijonen <sami.keijonen at foxnet.fi>
wrote:

> Thanks.
>
> I was thinking this kind of way of loading .min file for parent theme.
>
> /**
>  * The suffix to use for scripts.
>  */
> if ( ( defined( 'SCRIPT_DEBUG' ) && true === SCRIPT_DEBUG ) ) {
>  define( 'THEME_SUFFIX', '' );
> } else {
> define( 'THEME_SUFFIX', '.min' );
> }
>
>
> /* Enqueue parent theme styles. */
> wp_enqueue_style( 'theme-style', trailingslashit(
> get_template_directory_uri() ) . 'style' . THEME_SUFFIX . '.css', array(),
> THEME_VERSION );
>  /* Enqueue child theme styles. */
> if ( is_child_theme() ) {
>  wp_enqueue_style( 'theme-child-style', get_stylesheet_uri(), array(),
> null );
> }
>
>
> On 1 August 2014 21:03, Emil Uzelac <emil at uzelac.me> wrote:
>
>> It should be good, I have not find any issues with that. Not sure what
>> others think.
>>
>>
>> On Friday, August 1, 2014, Sami Keijonen <sami.keijonen at foxnet.fi> wrote:
>>
>>> Emil, is you example loading parent and child theme style.css allowed in
>>> .org? It's seems handy way of loading parent theme's style.min.css file.
>>>
>>>
>>> On 16 July 2014 22:36, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> Empties are ugly and not really needed.
>>>>
>>>> This is what I do for my clients:
>>>>
>>>>     // Parent theme style.
>>>>  wp_enqueue_style( 'my-style', get_template_directory_uri() .
>>>> '/style.css', array(), null );
>>>>  // Child theme style.
>>>>     if ( is_child_theme() ) {
>>>> wp_enqueue_style( 'my-child-style', get_stylesheet_uri(), array(), null
>>>> );
>>>>  }
>>>>
>>>> Parent style.css remains at the usual place and when child is active it
>>>> will add it's own stylesheet :)
>>>>
>>>> And of course no @imports either ;)
>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>>
>>> --
>>> Sami Keijonen
>>> Fox Holding Oy
>>> sami.keijonen at foxnet.fi
>>> foxnet.fi
>>> foxnet-themes.fi
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> --
> Sami Keijonen
> Fox Holding Oy
> sami.keijonen at foxnet.fi
> foxnet.fi
> foxnet-themes.fi
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140801/027021a7/attachment.html>