[theme-reviewers] paginate_links() function - Reopened tickets

[Ulrich Pogson]

@Afzaal - I thought it was ok as it was just a older and newer post link.

For others
https://github.com/Automattic/_s/blob/master/inc/template-tags.php#L14-L35

I tried to get the same result as the _s code with paginate_links() but
was unsuccessful.

@Chip Would that also mean theme authors would not able allowed to support
these plugins.
http://wordpress.org/plugins/wp-smart-pagination/
http://wordpress.org/plugins/wp-pagenavi/

---------
@Admins

Could we have a list of features which fall under this guideline?
"Themes are required to support core implementation of features if they
incorporate those features."

I know that a few are listed in the recommended
section<http://make.wordpress.org/themes/guidelines/guidelines-recommended/>and
the settings API/customizer API is an exception to this guideline.

Thanks.


On 15 April 2014 21:21, <wordpress at thinkupthemes.com> wrote:

> Hi Ulrich,
>
> Sure, I found the function _s_paging_nav() in inc/template-tags.php. In _s
> this function doesn't incorporate paginate_links(). I found this in the
> latest version of _s which I downloaded earlier from github.
>
> Let me know if I've misunderstood something.
>
> Afzaal
>
>
>
> Quoting Ulrich Pogson <grapplerulrich at gmail.com>:
>
>  @Afzaal _s does not have a custom pagination function. Could you share
>> where you found one?
>>
>>
>> On 15 April 2014 13:54, Chip Bennett <chip at chipbennett.net> wrote:
>>
>>  The Guideline in question here is that Themes are required to support
>>> core
>>> implementation of features if they incorporate those features. WordPress
>>> provides a paginated link function, paginate_links()<http://codex.
>>> wordpress.org/Function_Reference/paginate_links>.
>>>
>>> Thus, if Themes want to incorporate paginated links as a Theme feature,
>>> they must use the core function.
>>>
>>> The normal implementation is for the Theme to create a wrapper function
>>> that sets up the arguments array to pass to paginate_links(), and then
>>> output the result of paginate_links( $args ).
>>>
>>>
>>> On Tue, Apr 15, 2014 at 7:02 AM, <wordpress at thinkupthemes.com> wrote:
>>>
>>>
>>>> Hi all,
>>>>
>>>> Can I get some clarification on the use of paginate_links() as I notice
>>>> that quite a number of themes were reopened yesterday with this being a
>>>> common reason.
>>>>
>>>> I've checked the started theme _s and this function is not being used,
>>>> instead a custom theme function is used instead. Within twentyfourteen a
>>>> custom function is also used, however in this case paginate_links() is
>>>> used
>>>> to form part of the custom function so is used in the twentyfourteen
>>>> theme.
>>>>
>>>> Can a theme developer use a custom pagination function to output to a
>>>> template file, provided that the function itself incorporates the
>>>> WordPress
>>>> function paginate_links()?
>>>>
>>>> Thanks,
>>>>
>>>> Afzaal
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140415/c2aeaf26/attachment.html>