[theme-reviewers] Deregistering mediaelement style / script

[Emil Uzelac]

>From what I understood<https://wordpress.org/support/topic/making-mediaelementjs-responsive?replies=19#post-4788480>,
it is not needed to remove the stylesheet to get this "fixed".



On Thu, Apr 10, 2014 at 2:50 PM, Afzaal <wordpress at thinkupthemes.com> wrote:

> Hi Emil
>
> The author has given the following reason for deregistering the script:
>
> "The reason I deregister them is to change the built-in media player. The
> built-in version has a flaw when it comes to being responsive which could
> be changed with a small edit. Take a look at
> https://wordpress.org/support/topic/making-mediaelementjs-
> responsive?replies=19 and you will get it. I have also changed the style
> a bit to look more appealing. But this isn't used in Vanilj at all, and is
> one more thing that have been added with my new theme."
>
> Thanks again!
>
> Afzaal
>
>
>
>
> Quoting Emil Uzelac <emil at uzelac.me>:
>
>  What would be the reason to "remove" the stylesheet?
>>
>>
>> On Thu, Apr 10, 2014 at 2:32 PM, Afzaal <wordpress at thinkupthemes.com>
>> wrote:
>>
>>  Hi,
>>>
>>> I'm currently reviewing a theme where the author is deregistering a
>>> WordPress bundled stylesheet "wp-mediaelement". This is being done
>>> within a
>>> custom theme class and immediately the authors own stylesheet is being
>>> registered.
>>>
>>> Is there any problems with doing this? I know that deregistering some
>>> scripts such as jQuery are not allowed, so thought it best to ask.
>>>
>>> Thanks,
>>>
>>> Afzaal
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140410/6c29a526/attachment.html>