[theme-reviewers] ASCII art in header.php

[Ryan Cowles]

Thank you all for the feedback!

And Justin, I definitely agree that there is a place for Easter eggs. In
this case though, I'll recommend to the user that the ASCII-art in question
be removed, as it is a bit too much self-promotion.

Best,
Ryan



On Thu, Apr 3, 2014 at 8:15 PM, Edward Caissie <edward.caissie at gmail.com>wrote:

> I agree with the "fun" aspect of adding "Easter egg" bits of code but in
> the case of the theme in question, I think they have crossed the line.
>
> Edward Caissie
> aka Cais.
>
>
> On Thu, Apr 3, 2014 at 10:08 PM, Justin Tadlock <justin at justintadlock.com>wrote:
>
>>  I'm fine with fun things like ASCII-art as long as it's not publicly
>> visible in the HTML source like that.  Don't do things like this for brand
>> promotion though.  Do it for fun.  And, put it in functions.php or
>> style.css.
>>
>> WP has a long history of Easter eggs.  Even Kubrick has its own thing
>> (scroll to bottom):
>> http://themes.svn.wordpress.org/default/1.7.2/style.css
>>
>> I even dropped a quote from one of my favorite shows in my last theme for
>> fellow sci-fi nerds.
>>
>>
>> On 4/3/2014 7:37 PM, Chip Bennett wrote:
>>
>> I would consider an ASCII-art HTML "powered by datacube" comment to be
>> tacky and inappropriate promotion. AuthorURI is there, and equally publicly
>> visible in source, in style.css.
>>
>>
>> On Thu, Apr 3, 2014 at 8:32 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>
>>>  We don't have any specific requirements, however I would treat the
>>> ASCII like name="author", meaning it should not be in header.php.
>>>
>>>
>>>
>>>  On Thu, Apr 3, 2014 at 7:05 PM, Ryan Cowles <ryan.cowles at automattic.com
>>> > wrote:
>>>
>>>>  Howdy,
>>>>
>>>>  I've been reviewing a theme that includes a large ASCII art comment
>>>> in header.php. I imagine that this is not acceptable, but I can't seem to
>>>> tie it to a specific rule/guideline. Here's the file for reference:
>>>> https://themes.svn.wordpress.org/dc_genomics/1.0/header.php
>>>>
>>>>  Does this in fact violate any of the requirements? And if so, which
>>>> one?
>>>>
>>>>  Thanks!
>>>>  Ryan
>>>>
>>>>  _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140404/586bf85f/attachment.html>