[theme-reviewers] GPL and limiting usage

Andrew Nacin wp at andrewnacin.com
Fri Sep 20 21:51:06 UTC 2013


+1 everything Otto and Justin have been saying. I'm kind of confused why
there is even such a lengthy, dramatic discussion here. (That is
rhetorical; I don't require an answer and don't intend to be dragged in.)

I'll just chime in on a single thing I noticed:

On Fri, Sep 20, 2013 at 4:14 PM, Justin Tadlock <justin at justintadlock.com>wrote:

>     <?php if(!pl_is_pro()):?>
>         <a class="pl-credit" href="http://www.pagelines.**com/<http://www.pagelines.com/>"
> title="Built with PageLines DMS [basic]" target="_blank" style="display:
> block !important; visibility: visible !important; opacity: 1 !important;">
>             <i class="icon-pagelines pl-transit"></i> <span
> class="fademein">DMS</span>
>         </a>
>     <?php endif; ?>


Credit links are allowed, of course. But they shouldn't be *forced* upon a
user. The inline styles here appear to have no legitimate purpose, and
instead exist to set up a deliberate barrier to removing the credit link.
Yes, someone can go into footer.php and remove this code. But they should
also be able to do that with CSS. That entire style attribute is against
the spirit of the guidelines and, I would argue, should be removed from the
theme. I'll be posting this to the ticket.

(To be clear: I don't expect the guidelines to suddenly grow a new page of
requirements over !important inline styles on credit links. This is just
basic common sense. Credit links are allowed, but you shouldn't be a dick
about it.)

The only two cents I am providing today.
Nacin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130920/60796c89/attachment.html>


More information about the theme-reviewers mailing list