[theme-reviewers] Feedback on use of query_posts please - Badidea?

Zulfikar Nore zulfikarnore at live.com
Sat Sep 14 02:11:07 UTC 2013


Right on Phil.
I have this loop working but for the pagination: https://gist.github.com/zulfnore/6558084
Any pointers?

From: philip at frumph.net
To: theme-reviewers at lists.wordpress.org
Date: Fri, 13 Sep 2013 18:51:47 -0700
Subject: Re: [theme-reviewers] Feedback on use of query_posts please -	Badidea?





because he’s probably making a ‘page’ that is off the /index/home/ it’s a 
template... i.e. not the landing, lotsa people do this ;/  splash page in 
the front, link in menu to the actual blog loop
 
 
 
 


 

From: Chip Bennett 
Sent: Friday, September 13, 2013 6:42 PM
To: Discussion list for WordPress 
theme reviewers. 
Subject: Re: [theme-reviewers] Feedback on use of query_posts please 
- Badidea?
 

Why do you need template-blog.php when there is home.php for 
exactly that purpose?



On Fri, Sep 13, 2013 at 8:22 PM, Zulfikar Nore <zulfikarnore at live.com> wrote:


  
  I've read around that using query_posts is bad but I've seen many 
  a themes using it and get away with it. 
   
  My case is I'm trying to put together a template-blog.php for StrapVert 
  and this is what I've come up with so far:
   
  
  add_filter('option_show_on_front', '__return_false');
    global $wp_query;
      query_posts(array(
    'paged' => 
  $wp_query->get('paged'),
    'post__not_in' => 
  get_option('sticky_posts'),
      ));
   
    global $more; $more = 0;
      get_template_part('index-blog');
         $more = 1;
  remove_filter('option_show_on_front', '__return_false');
   
     wp_reset_query();
  wp_reset_postdata();
   
  But before I add these changes to the theme and submit an update I'd like 
  some feedback on "How Really Bad" is query_posts and can I "get away" with the 
  above?
   
  Thanks in advance,
  Zulf 
  
_______________________________________________
theme-reviewers 
  mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers


 



_______________________________________________
theme-reviewers mailing 
list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers


_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130914/faefdd17/attachment-0001.html>


More information about the theme-reviewers mailing list