[theme-reviewers] Feedback on use of query_posts please - Bad idea?

[Philip M. Hofer (Frumph)]

You probably should be using new $wp_query

mines not the best but here’s my blog.php

https://github.com/Frumph/comicpress/blob/master/blog.php



From: Zulfikar Nore 
Sent: Friday, September 13, 2013 5:22 PM
To: Theme Reviewers 
Subject: [theme-reviewers] Feedback on use of query_posts please - Bad idea?

I've read around that using query_posts is bad but I've seen many a themes using it and get away with it. 

My case is I'm trying to put together a template-blog.php for StrapVert and this is what I've come up with so far:

add_filter('option_show_on_front', '__return_false');
  global $wp_query;
    query_posts(array(
  'paged' => $wp_query->get('paged'),
  'post__not_in' => get_option('sticky_posts'),
    ));

  global $more; $more = 0;
    get_template_part('index-blog');
       $more = 1;
remove_filter('option_show_on_front', '__return_false');

   wp_reset_query();
wp_reset_postdata();

But before I add these changes to the theme and submit an update I'd like some feedback on "How Really Bad" is query_posts and can I "get away" with the above?

Thanks in advance,
Zulf 


--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130913/45003699/attachment.html>