[theme-reviewers] Is SMOF framework allowed?

Tue Sep 10 16:17:21 UTC 2013

Ok it had other issues so not approved it as new trac will put the next
ticket in #1 and theme author won't loose any time waiting.
But is it necessary to change it? I remember you saying such requests are
not legally binding in an another similar scenario, can't seem to find that
ticket tough.

On Tue, Sep 10, 2013 at 9:43 PM, Chip Bennett <chip at chipbennett.net> wrote:

> I would approve (assuming no other issues), but require the developer to
> replace SMOF in the next revision.
>
>
> On Tue, Sep 10, 2013 at 12:09 PM, Srikanth Koneru <tskk79 at gmail.com>wrote:
>
>> If an already approved theme is using SMOF, should i not-approve it or
>> can it stay?
>>
>>
>> On Fri, Sep 6, 2013 at 12:14 AM, Towfiq I. <tislam100 at gmail.com> wrote:
>>
>>> I found another options framework, released under GPL v3. Should I use
>>> this:
>>> http://en.bainternet.info/2012/my-options-panel
>>> https://github.com/bainternet/Admin-Page-Class
>>>
>>> Thanks
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Sep 5, 2013 at 11:49 PM, Towfiq I. <tislam100 at gmail.com> wrote:
>>>
>>>> damn. I started building my new theme with SMOF. :/
>>>> I preferred SMOF over original options framework because of the backup
>>>> options feature.
>>>>
>>>>
>>>> On Thu, Sep 5, 2013 at 11:47 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>
>>>>> If I were reviewing a Theme that bundled SMOF, I would challenge the
>>>>> GPL-compatibility of the license terms. So, I would say "no".
>>>>>
>>>>>
>>>>> On Thu, Sep 5, 2013 at 1:45 PM, Towfiq I. <tislam100 at gmail.com> wrote:
>>>>>
>>>>>> So is it allowed to use the SMOF?
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 5, 2013 at 11:34 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>>>>
>>>>>>> Awesome :)
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Sep 5, 2013 at 12:33 PM, Towfiq I. <tislam100 at gmail.com>wrote:
>>>>>>>
>>>>>>>> Thanks Emil. This is what I was referring to.yes.
>>>>>>>>
>>>>>>>> and I use options framework by devin in my themes. So the points
>>>>>>>> mentioned by Chip is already being done in my themes.
>>>>>>>> and yes Chip I was thinking that too. Its an overkill..
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Sep 5, 2013 at 11:29 PM, Emil Uzelac <emil at uzelac.me>wrote:
>>>>>>>>
>>>>>>>>> What Towfiq was saying is something like this:
>>>>>>>>> http://www.presscoders.com/2011/10/better-theme-activation-handling/
>>>>>>>>>
>>>>>>>>> But I like what @Chip linked better :)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Sep 5, 2013 at 12:20 PM, <wordpress at thinkupthemes.com>wrote:
>>>>>>>>>
>>>>>>>>>> Totally agree! The theme should still look like a theme when
>>>>>>>>>> activated. I'd suggest that you have clear documentation so users know they
>>>>>>>>>> can change options from the theme options page. Make it super clear.
>>>>>>>>>>
>>>>>>>>>> So would I be right in assuming that SMOF is allowed then? I'll
>>>>>>>>>> submit my theme next week and can completely strip it out if SMOF is not
>>>>>>>>>> allowed, but didn't want to as I thought it would be cool to give a premium
>>>>>>>>>> level theme for free.
>>>>>>>>>>
>>>>>>>>>> Afzaal
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Quoting Chip Bennett <chip at chipbennett.net>:
>>>>>>>>>>
>>>>>>>>>>  You should never, ever need to redirect the user to the Theme
>>>>>>>>>>> options page
>>>>>>>>>>> upon activation.
>>>>>>>>>>>
>>>>>>>>>>> Instead, the Theme should define and use sane defaults as a
>>>>>>>>>>> fallback, in
>>>>>>>>>>> case the user does not configure Theme options.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Sep 5, 2013 at 1:01 PM, Towfiq I. <tislam100 at gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>  on a different note, is it possible to redirect the user to
>>>>>>>>>>>> theme options
>>>>>>>>>>>> page after activating the theme? If so, how?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Sep 5, 2013 at 10:58 PM, <wordpress at thinkupthemes.com>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>  Thanks Harish,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Great idea. I'll add a recommendation for the plugin to be
>>>>>>>>>>>>> installed
>>>>>>>>>>>>> using TGM activation. Thanks, I'll remove this and take your
>>>>>>>>>>>>> advice.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Afzaal
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Quoting Harish <me at harishchouhan.com>:
>>>>>>>>>>>>>
>>>>>>>>>>>>>  Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Any reason why you want to roll in the twitter widget in your
>>>>>>>>>>>>>> theme?
>>>>>>>>>>>>>> Simply
>>>>>>>>>>>>>> show a message after activation to help people download the
>>>>>>>>>>>>>> plugin. Will
>>>>>>>>>>>>>> make your theme smaller and if the users change theme, they
>>>>>>>>>>>>>> won't lose
>>>>>>>>>>>>>> their
>>>>>>>>>>>>>> twitter widget.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>>> Harish Chouhan
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Visit me at - www.harishchouhan.com
>>>>>>>>>>>>>> Phone: +91-9833661410 | Email: me at harishchouhan.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> -----Original Message-----
>>>>>>>>>>>>>> From: theme-reviewers [mailto:theme-reviewers-**
>>>>>>>>>>>>>> bounces at lists.wordpress.org<th**eme-reviewers-bounces at lists.*
>>>>>>>>>>>>>> *wordpress.org <theme-reviewers-bounces at lists.wordpress.org>>
>>>>>>>>>>>>>> ]
>>>>>>>>>>>>>> On Behalf Of wordpress at thinkupthemes.com
>>>>>>>>>>>>>> Sent: Thu 05 September 13 10:21 PM
>>>>>>>>>>>>>> To: theme-reviewers at lists.**wordpr**ess.org<http://wordpress.org>
>>>>>>>>>>>>>> <theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>> Subject: [theme-reviewers] Is SMOF framework allowed?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hello all,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'm in the final stages of completing my WordPress theme and
>>>>>>>>>>>>>> think people
>>>>>>>>>>>>>> may find it useful so am thinking about trying to get it into
>>>>>>>>>>>>>> the
>>>>>>>>>>>>>> WordPress
>>>>>>>>>>>>>> repository. I've noticed a few warnings however that have
>>>>>>>>>>>>>> appeared when
>>>>>>>>>>>>>> running theme-check.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 1. base64_encode error in the framework SMOF. I used this
>>>>>>>>>>>>>> because of the
>>>>>>>>>>>>>> referral on http://codex.wordpress.org/****Theme_Frameworks<http://codex.wordpress.org/**Theme_Frameworks>
>>>>>>>>>>>>>> <http://codex.**wordpress.org/Theme_Frameworks<http://codex.wordpress.org/Theme_Frameworks>
>>>>>>>>>>>>>> **>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> .
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 2. base64_encode in the Twitter feed widget which I've
>>>>>>>>>>>>>> packaged into the
>>>>>>>>>>>>>> theme http://wordpress.org/plugins/****tweetscroll-widget/<http://wordpress.org/plugins/**tweetscroll-widget/>
>>>>>>>>>>>>>> <http://**wordpress.org/plugins/**tweetscroll-widget/<http://wordpress.org/plugins/tweetscroll-widget/>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> .
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If anyone can shed any light on if these are major errors I'd
>>>>>>>>>>>>>> really
>>>>>>>>>>>>>> appreciate your help. I really want to make sure that my
>>>>>>>>>>>>>> themes are 100%
>>>>>>>>>>>>>> safe so am spending a lot of time on finding any errors.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thank you so much in advance.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Afzaal
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ______________________________****_________________
>>>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>>> theme-reviewers at lists.**wordpr**ess.org<http://wordpress.org>
>>>>>>>>>>>>>> <theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>> http://lists.wordpress.org/****mailman/listinfo/theme-****
>>>>>>>>>>>>>> reviewers<http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers>
>>>>>>>>>>>>>> <http://lists.**wordpress.org/mailman/**
>>>>>>>>>>>>>> listinfo/theme-reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ______________________________****_________________
>>>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>>> theme-reviewers at lists.**wordpr**ess.org<http://wordpress.org>
>>>>>>>>>>>>>> <theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>> http://lists.wordpress.org/****mailman/listinfo/theme-****
>>>>>>>>>>>>>> reviewers<http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers>
>>>>>>>>>>>>>> <http://lists.**wordpress.org/mailman/**
>>>>>>>>>>>>>> listinfo/theme-reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>>>>>>>>>> >
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> ______________________________****_________________
>>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> theme-reviewers at lists.**wordpr**ess.org <http://wordpress.org>
>>>>>>>>>>>>> <theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>>>>> >
>>>>>>>>>>>>> http://lists.wordpress.org/****mailman/listinfo/theme-****
>>>>>>>>>>>>> reviewers<http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers>
>>>>>>>>>>>>> <http://lists.**wordpress.org/mailman/**
>>>>>>>>>>>>> listinfo/theme-reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>>>>>>>>> >
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Towfiq I.
>>>>>>>>>>>>
>>>>>>>>>>>> ______________________________**_________________
>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ______________________________**_________________
>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>>>>>>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Towfiq I.
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> theme-reviewers mailing list
>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Towfiq I.
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Towfiq I.
>>>>
>>>
>>>
>>>
>>> --
>>> Towfiq I.
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130910/312bffb4/attachment-0001.html>