[theme-reviewers] wp_mav_menu using bootstrap

Tue Sep 3 18:15:03 UTC 2013

Thanks Ash.
I'm working on that for theme's I release publicly - those two are for developers to take and do their own thing with.
Downloaded your theme and going to study how you've done yours and see if I can improvise with it :)The problem I've found so far is Bootstrap menu doesn't play nice with WordPress menu fallback and even if you get it to work there's always some nagging issues with it.
Cheers,Zulf

Date: Tue, 3 Sep 2013 23:37:42 +0530
From: wp at devcorn.com
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] wp_mav_menu using bootstrap

Looks great Zgani, but I see you also didn't implement menu fallback and most of bootstrap themes in directory doesn't implement fallback menu in case none is selected? 

I am pretty new to theme development and I tried to implement it in my theme , it works and reviewed.. but not sure if what I have done was the way or it was unnecessary? I believe WordPress core should have taken care it.

http://wordpress.org/themes/bikaner

-Ash
http://devcorn.com

On Tue, Sep 3, 2013 at 8:52 PM, Zulfikar Nore <zulfikarnore at live.com> wrote:

Anyone interested in Bootstrap themeing can use my "improvisation" of a framework - built on Underscores and Bootstrap :)
You can grab it at http://www.wpstrapcode.com/theme-developers-framework - there are two versions, take your pick or take them both.

Regards,Zulf AKA ZGani

Date: Tue, 3 Sep 2013 16:17:36 +0530
From: wp at devcorn.com
To: theme-reviewers at lists.wordpress.org

Subject: Re: [theme-reviewers] wp_mav_menu using bootstrap

Apart from extending , this is what I am doing.
in header.php
<?php wp_nav_menu( array( 'theme_location' => 'primary', 'menu_class' => 'navbar-nav nav ' , 'container_class' => 'collapse navbar-collapse primary-menu-collapse','walker' => new bikaner_walker_nav_menu(),'fallback_cb'=>'bikaner_wp_page_menu' )); ?>

and following in bikaner_wp_page_menu in functions.php
761 : $list_args['walker'] = new bikaner_walker_page_menu;

Let me know if you need more details.

ThanksAsh

On Tue, Sep 3, 2013 at 4:05 PM, devcorn <wp at devcorn.com> wrote:

And I have one based on bootstrap3 , It is reviewed by WRT and in directory ... you need to extend the walker class.. 

http://wordpress.org/themes/bikaner

On Tue, Sep 3, 2013 at 11:24 AM, Emil Uzelac <emil at uzelac.me> wrote:

>From one of the previous reviewers http://wordpress.org/themes/the-bootstrap good stuff there :-D

On Sep 3, 2013 12:47 AM, "Srikanth Koneru" <tskk79 at gmail.com> wrote:

Or look at one of zgani's themes, he is obsessed with bootstrap :)

On Tue, Sep 3, 2013 at 11:09 AM, Konrad Sroka <konrads at themekraft.com> wrote:

Hey Priyanshu, 
we just built a WordPress Starter Theme based on Twitter Bootstrap 3.0 and Underscores (_s). 

And it aligns 100% with the WordPress Theme Review Guidelines. (please correct me anyone if I should be wrong) 

Maybe you can find some inspiration in our nav walker or other stuff ;-) 
Project @ Github: https://github.com/Themekraft/_tk 

Cheers, Konrad

On 3 September 2013 06:26, priyanshu mittal <priyanshu.mittal at gmail.com> wrote:

Hey I am using bootstrap for my next theme and getting some problems with menu which is, wp_page_menu is not supporting bootstrap nav walker

wp_nav_menu is working fine but when there is no custom menu or location than in that case the default fallback must work which is wp_page_menu, because i want to maintain responsiveness with the page links as well

Any suggestions?

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers

-- 

i.A. Konrad Sroka Themekraft  UG haftungsbeschränkt 

Beautiful Themes and Plugins for WordPress and BuddyPress 
web - http://themekraft.com 

mail - konrads at themekraft.com 

Höhenstrasse 55 
D-40227 Düsseldorf 

Germany  
HRB 66772, Gerichtsstand Düsseldorf, deutsches Recht  

Geschäftsführung / Managing Director: Sven Lehnert 
USt-ID: DE282376267

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 		 	   		  

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130903/df578e8e/attachment-0001.html>