[theme-reviewers] Upgrading Masonry In Core

[Rohit Tripathi]

Yes, I understand that.
Some compatibility should be provided up till next 2 versions. I feel, it should be core's responsibility to provide backwards compatibility for themes using masonry v2. I don't know how to explain this, but isn't it quite obvious?

From: jpollock412 at gmail.com
Date: Sat, 23 Nov 2013 16:10:58 -0500
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Upgrading Masonry In Core

I made a new diff based on your feedback. Thanks. BTW I wouldn't go as so fat as to say 'this upgrade is being made.' Until we get this tested throughly, ie someone runs the unit tests on it, and we attract some interest from the project leads, it's not going to get made.

I guess the breaking themes issue is more of a issue of policy and/ or philosophy. Yes the upgrade will break stuff. Is it the responsibility of core to write in the backwards compatibility or is it responsibility of theme/plugin developer to fix it.



On Sat, Nov 23, 2013 at 4:01 PM, Rohit Tripathi <rohitink at live.com> wrote:





Hi. I have Replied to the ticket with a few more changes that needed to be made in the diff you submitted. Its great to see, that this upgrade is being made.


Answer to your other Question. Yes, themes are likely to suffer with this upgrade, as 5 of the very commonly used parameters were renamed in masonry v3. Hence, some sort of backword compatibilty is needed.



From: jpollock412 at gmail.com
Date: Sat, 23 Nov 2013 15:36:46 -0500
To: theme-reviewers at lists.wordpress.org


Subject: [theme-reviewers] Upgrading Masonry In Core

We discussed the need to upgrade Masonry in core to version 3 awhile back. I have submitted a new patch that not only updates Masonry to version 3 but also addresses the fact that doing so initially broke the footer widgets in 2013 and 2014 due to the different way that v2 and v3 handle column width.




http://core.trac.wordpress.org/ticket/25351

This raises a relevant question:Would anyone's theme experience a similar issue? Probably. Is that a valid objection to upgrading in core?




BTW If anyone has a second to test and/ or improve on my patch it would be appreciated. I'd like to get this fairly simple upgrade done soon.

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 		 	   		  

_______________________________________________

theme-reviewers mailing list

theme-reviewers at lists.wordpress.org

http://lists.wordpress.org/mailman/listinfo/theme-reviewers





_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20131124/7b205a75/attachment.html>