[theme-reviewers] FavePersonal Theme

[WordPress (thinkupthemes)]

Why are you including the plugin in your theme? Why not just use TGM to recommend it as an install after the theme is activated?

Afzaal


Sent from my iPhone

On 14 Nov 2013, at 00:22, Alex King <lists at alexking.org> wrote:

> Hello--
> 
> I got some errors when I tried to submit our FavePersonal theme to the repo:
> 
>    • WARNING: Found base64_encode in the file twitter.php. base64_encode() is not allowed.
>    • WARNING: Found base64_encode in the file social.php. base64_encode() is not allowed.
>    • WARNING: Found base64_encode in the file social-twitter.php. base64_encode() is not allowed.
>    • WARNING: Found base64_encode in the file facebook.php. base64_encode() is not allowed.
>    • WARNING: Found base64_decode in the file social-twitter.php. base64_decode() is not allowed.
>    • WARNING: Found base64_decode in the file broadcast.php. base64_decode() is not allowed.
>    • WARNING: fwrite was found in the file build.php possible file operations.
>    • WARNING: fopen was found in the file log.php possible file operations.
>    • WARNING: fopen was found in the file build.php possible file operations.
>    • WARNING: file_put_contents was found in the file cf-favicon-fetch.class.php possible file operations.
>    • WARNING: file_get_contents was found in the file build.php possible file operations.
>    • WARNING: fclose was found in the file log.php possible file operations.
>    • WARNING: fclose was found in the file build.php possible file operations.
>    • WARNING: curl_init was found in the file cf-colors.php possible file operations.
>    • WARNING: curl_exec was found in the file cf-colors.php possible file operations.
>    • WARNING: .htaccess Hidden Files or Folders found.
>    • REQUIRED: social.php. Themes should use add_theme_page() for adding admin pages.
>    • REQUIRED: create_user found in the file service.php. Deprecated since version 2.0. Use wp_create_user() instead.
> 
> These errors are all within the Social plugin that is included with the theme:
> 
> http://wordpress.org/plugins/social/
> 
> Can you please grant an exception for this? Thanks.
> 
> We'll look at addressing some of the other recommendations in the next release.
> 
> http://d.pr/f/iHCe (theme archive)
> 
> Cheers,
> --Alex
> 
> http://alexking.org | http://crowdfavorite.com
> 
> 
> 
> 
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers