[theme-reviewers] PHP namespace

[Chip Bennett]

Not suppressing errors is inherent in the guideline regarding not throwing
any PHP notices/errors. If Themes could avoid throwing errors via error
suppression, that guideline becomes moot.


On Wed, May 22, 2013 at 4:03 PM, Edward Caissie <edward.caissie at gmail.com>wrote:

> It looked like "error suppression" to me as well, but we do not have any
> current guidelines referencing that technique ... or do we?
>
> Edward Caissie
> aka Cais.
>
>
> On Wed, May 22, 2013 at 4:02 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> The issue of passing anonymous functions to hooks is certainly valid.
>> Hooks must reference a valid callback, so that they can be overridden.
>>
>> Another major concern is that the Theme *requires* a PHP version higher
>> than that required by WordPress core.
>>
>> I also agree on the overall structure of the Theme; it completely
>> circumvents the template hierarchy in a way that would prove extremely
>> difficult for an end user to overcome.
>>
>> I also see what I think is error suppression?
>>
>>
>> On Wed, May 22, 2013 at 3:46 PM, esmi at quirm dot net <esmi at quirm.net>wrote:
>>
>>> <https://themes.trac.**wordpress.org/ticket/12206<https://themes.trac.wordpress.org/ticket/12206>
>>> >
>>>
>>> Is using <?php namespace theme; ?> a reasonable excuse for then using
>>> 'theme' as a textdomain? My gut instinct says "no".
>>>
>>> That said, this theme is totally unlike any standard WPORG theme. The
>>> whole thing is pure actions hooks & filters (which is cool) but...
>>>
>>> 1. functions are not being named. - they're being added (wholesale) as
>>> the second argument to add_action and add_filter.
>>> 2. locate_template() is being used instead of get_template().
>>>
>>> In general, trying to apply the guidelines to this theme is like trying
>>> to plait fog. It looks more like it's intended as a framework than a theme.
>>> Anyone care to weigh in?
>>>
>>> Mel
>>> --
>>> http://quirm.net
>>> http://blackwidows.co.uk
>>> ______________________________**_________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130522/5c67d2bf/attachment.html>