[theme-reviewers] PHP namespace

[Edward Caissie]

Yes, it does appear to be a challenging review ...

... <?php namespace theme; ?> will not work as a textdomain item. As Simon
noted it is more a PHP item (IIRC, it is for establishing a namespace for
the software which would work in favor of reducing/eliminating clashes with
other PHP functions, etc.)

Also to note, 'theme' is not a very good textdomain to begin with ... the
theme slug would be more appropriate; and, the logo as a screenshot is
typically not acceptable either.

Edward Caissie
aka Cais.


On Wed, May 22, 2013 at 3:46 PM, esmi at quirm dot net <esmi at quirm.net>wrote:

> <https://themes.trac.**wordpress.org/ticket/12206<https://themes.trac.wordpress.org/ticket/12206>
> >
>
> Is using <?php namespace theme; ?> a reasonable excuse for then using
> 'theme' as a textdomain? My gut instinct says "no".
>
> That said, this theme is totally unlike any standard WPORG theme. The
> whole thing is pure actions hooks & filters (which is cool) but...
>
> 1. functions are not being named. - they're being added (wholesale) as the
> second argument to add_action and add_filter.
> 2. locate_template() is being used instead of get_template().
>
> In general, trying to apply the guidelines to this theme is like trying to
> plait fog. It looks more like it's intended as a framework than a theme.
> Anyone care to weigh in?
>
> Mel
> --
> http://quirm.net
> http://blackwidows.co.uk
> ______________________________**_________________
> theme-reviewers mailing list
> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130522/e68bdf29/attachment.html>