[theme-reviewers] PHP namespace
chip at chipbennett.net
Wed May 22 20:02:13 UTC 2013
The issue of passing anonymous functions to hooks is certainly valid. Hooks
must reference a valid callback, so that they can be overridden.
Another major concern is that the Theme *requires* a PHP version higher
than that required by WordPress core.
I also agree on the overall structure of the Theme; it completely
circumvents the template hierarchy in a way that would prove extremely
difficult for an end user to overcome.
I also see what I think is error suppression?
On Wed, May 22, 2013 at 3:46 PM, esmi at quirm dot net <esmi at quirm.net>wrote:
> Is using <?php namespace theme; ?> a reasonable excuse for then using
> 'theme' as a textdomain? My gut instinct says "no".
> That said, this theme is totally unlike any standard WPORG theme. The
> whole thing is pure actions hooks & filters (which is cool) but...
> 1. functions are not being named. - they're being added (wholesale) as the
> second argument to add_action and add_filter.
> 2. locate_template() is being used instead of get_template().
> In general, trying to apply the guidelines to this theme is like trying to
> plait fog. It looks more like it's intended as a framework than a theme.
> Anyone care to weigh in?
> theme-reviewers mailing list
> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers