[theme-reviewers] Editing core shortcodes (Gallery)

[Daniel Tara]

> I'm not sure if the theme or the plugin should have the priority. As
> Otto mentioned, he would like the theme to handle the gallery
> customization. Others like you would like the plugin to take over.
> Setting a standard would help, you're right, but some people won't be
> happy about it. :)

If you don't want it then you disable the plugin or at least the Tiled Gallery module. What't the point of having it active if you don't want it? The thing I like most about Jetpack is that although it's a bundle of functions each one can be individually deactivated. I believe this approach makes for much a easier to maintain codebase while allowing the flexibility of user preference. But I don't understand the redundancy: Why make checks if one can manually choose wether to use it or not? I believe activating a module and not see it work means broken functionality for average users. I'm saying this because that check is probably intended to help users but in my opinion it's doing them a huge disservice.

Daniel

On Mar 26, 2013, at 9:49 PM, Jeremy Herve wrote:

> On Tue, Mar 26, 2013 at 8:30 PM, Otto <otto at ottodestruct.com> wrote:
>> The proper place for gallery customization is in the theme. The theme
>> controls the presentation, the layout, the site design. How the
>> pictures look on the page is clearly part of that, and Jetpack is
>> doing-it-wrong by assuming that such functionality should be in a
>> plugin at all.
> 
> While I get your point, limiting gallery customization to themes would
> mean that all lightbox/thickbox/fancybox/... plugins would be added to
> themes instead of plugins. I wouldn't be too happy about that, but I
> guess we can agree to disagree :)
> 
>> It's extremely difficult for a theme to say "hey, my code is
>> just as good as core's, go ahead and turn on the tiled galleries" or
>> similar.
> 
> Completely agree with you here.
> 
> On Tue, Mar 26, 2013 at 8:31 PM, Daniel Tara <contact at onedesigns.com> wrote:
>> The thing with Jetpack is that they also have a check that breaks their code if they find another theme or plugin has hooked to it. They said in the code it's because of compatibility with the WP.com VIP feature. Maybe I'm missing something but I personally don't see the reason for such checks, that's what priorities are for. I believe plugins should have priority over themes because if the user has the plugin active it's obvious he wants to use it while not so obvious about the theme. The WP.com VIP module could also hook with a greater priority than Jetpack. If we set up this simple standard I believe it would be more easier to handle such situations.
> 
> I'm not sure if the theme or the plugin should have the priority. As
> Otto mentioned, he would like the theme to handle the gallery
> customization. Others like you would like the plugin to take over.
> Setting a standard would help, you're right, but some people won't be
> happy about it. :)
> 
> In any case we need to do a better job at warning the users when a
> conflict appears between 2 gallery customizations.
> 
> Jeremy
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers