[theme-reviewers] Editing core shortcodes (Gallery)

Otto otto at ottodestruct.com
Tue Mar 26 19:30:07 UTC 2013


On Tue, Mar 26, 2013 at 1:45 PM, Jeremy Herve <jeremy at jeremyherve.com> wrote:
> That's why I'd prefer for such functions to be added by plugins.

Honestly, I think that the gallery functionality in Jetpack shouldn't
be in Jetpack at all. It's out of place.

The proper place for gallery customization is in the theme. The theme
controls the presentation, the layout, the site design. How the
pictures look on the page is clearly part of that, and Jetpack is
doing-it-wrong by assuming that such functionality should be in a
plugin at all.

More to the point, Jetpack is most definitely doing-it-wrong by making
it difficult for themes to declare that they use core-compatible HTML
in their custom gallery implementations. If I use a custom gallery to,
say, add comment-counts to the excerpts displayed with a gallery, then
Jetpack wrongly detects and self-disables because I've used a custom
gallery. It's extremely difficult for a theme to say "hey, my code is
just as good as core's, go ahead and turn on the tiled galleries" or
similar.

-Otto


More information about the theme-reviewers mailing list